Re: [PATCH v3 13/14] tracing/selftest: Add selftests to test trace_marker histogram triggers

2018-05-30 Thread Masami Hiramatsu
On Mon, 28 May 2018 21:20:55 -0400 Steven Rostedt wrote: > On Mon, 28 May 2018 01:32:58 +0900 > Masami Hiramatsu wrote: > > > Hi Steve, > > > > On Fri, 25 May 2018 17:13:53 -0400 > > Steven Rostedt wrote: > > > > > On Fri, 25 May 2018 17:12:29 -0400 > > > Steven Rostedt wrote: > > > > > >

Re: [PATCH v3 13/14] tracing/selftest: Add selftests to test trace_marker histogram triggers

2018-05-28 Thread Steven Rostedt
On Mon, 28 May 2018 01:32:58 +0900 Masami Hiramatsu wrote: > Hi Steve, > > On Fri, 25 May 2018 17:13:53 -0400 > Steven Rostedt wrote: > > > On Fri, 25 May 2018 17:12:29 -0400 > > Steven Rostedt wrote: > > > > > > > #!/bin/sh > > > > Hmm, I think I need to make this #!/bin/bash > >

Re: [PATCH v3 13/14] tracing/selftest: Add selftests to test trace_marker histogram triggers

2018-05-27 Thread Masami Hiramatsu
Hi Steve, On Fri, 25 May 2018 17:13:53 -0400 Steven Rostedt wrote: > On Fri, 25 May 2018 17:12:29 -0400 > Steven Rostedt wrote: > > > > #!/bin/sh > > Hmm, I think I need to make this #!/bin/bash > > > test_trace() { > > file=$1 > > x=$2 > > > > cat $file | while read line; do

Re: [PATCH v3 13/14] tracing/selftest: Add selftests to test trace_marker histogram triggers

2018-05-25 Thread Steven Rostedt
On Fri, 25 May 2018 17:12:29 -0400 Steven Rostedt wrote: > #!/bin/sh Hmm, I think I need to make this #!/bin/bash > test_trace() { > file=$1 > x=$2 > > cat $file | while read line; do > if [ "$line" != "${line/\#/}" ]; then > continue > fi > echo "test

Re: [PATCH v3 13/14] tracing/selftest: Add selftests to test trace_marker histogram triggers

2018-05-25 Thread Steven Rostedt
On Fri, 25 May 2018 14:07:31 -0400 Steven Rostedt wrote: > > > > BTW, would you plan to add simplar test case for the marker? > > (like just write a marker and read trace log, and run a simple > > trigger, like taking a snapshot by marker) > > I wasn't planning to, but I could. Like someth

Re: [PATCH v3 13/14] tracing/selftest: Add selftests to test trace_marker histogram triggers

2018-05-25 Thread Steven Rostedt
On Wed, 23 May 2018 23:13:31 +0900 Masami Hiramatsu wrote: > This looks good to me. > > Acked-by: Masami Hiramatsu Thanks! > > BTW, would you plan to add simplar test case for the marker? > (like just write a marker and read trace log, and run a simple > trigger, like taking a snapshot by m

Re: [PATCH v3 13/14] tracing/selftest: Add selftests to test trace_marker histogram triggers

2018-05-23 Thread Masami Hiramatsu
On Wed, 16 May 2018 11:00:25 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Add a couple of tests that test the trace_marker histogram triggers. > One does a straight histogram test, the other will create a synthetic event > and test the latency between two different writes (

[PATCH v3 13/14] tracing/selftest: Add selftests to test trace_marker histogram triggers

2018-05-16 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Add a couple of tests that test the trace_marker histogram triggers. One does a straight histogram test, the other will create a synthetic event and test the latency between two different writes (using filters to differentiate between them). Signed-off-by: Steven