Re: [PATCH v3 13/16] exit: Factor thread_group_exited out of pidfd_poll

2020-07-07 Thread Eric W. Biederman
Daniel Borkmann writes: > Hey Eric, are you planning to push the final version into a topic branch > so it can be pulled into bpf-next as discussed earlier? Yes. I just about have it ready. I am taking one last pass through the review comments to make certain I have not missed anything before

Re: [PATCH v3 13/16] exit: Factor thread_group_exited out of pidfd_poll

2020-07-07 Thread Daniel Borkmann
On 7/7/20 7:09 PM, Eric W. Biederman wrote: Christian Brauner writes: On Fri, Jul 03, 2020 at 04:37:47PM -0500, Eric W. Biederman wrote: Alexei Starovoitov writes: On Thu, Jul 02, 2020 at 11:41:37AM -0500, Eric W. Biederman wrote: Create an independent helper thread_group_exited report ret

Re: [PATCH v3 13/16] exit: Factor thread_group_exited out of pidfd_poll

2020-07-07 Thread Eric W. Biederman
Christian Brauner writes: > On Fri, Jul 03, 2020 at 04:37:47PM -0500, Eric W. Biederman wrote: >> Alexei Starovoitov writes: >> >> > On Thu, Jul 02, 2020 at 11:41:37AM -0500, Eric W. Biederman wrote: >> >> Create an independent helper thread_group_exited report return true >> >> when all thread

Re: [PATCH v3 13/16] exit: Factor thread_group_exited out of pidfd_poll

2020-07-04 Thread Christian Brauner
On Thu, Jul 02, 2020 at 11:41:37AM -0500, Eric W. Biederman wrote: > Create an independent helper thread_group_exited report return true s/report return/which reports/ > when all threads have passed exit_notify in do_exit. AKA all of the > threads are at least zombies and might be dead or comple

Re: [PATCH v3 13/16] exit: Factor thread_group_exited out of pidfd_poll

2020-07-04 Thread Christian Brauner
On Fri, Jul 03, 2020 at 04:37:47PM -0500, Eric W. Biederman wrote: > Alexei Starovoitov writes: > > > On Thu, Jul 02, 2020 at 11:41:37AM -0500, Eric W. Biederman wrote: > >> Create an independent helper thread_group_exited report return true > >> when all threads have passed exit_notify in do_exi

Re: [PATCH v3 13/16] exit: Factor thread_group_exited out of pidfd_poll

2020-07-03 Thread Alexei Starovoitov
On Fri, Jul 03, 2020 at 04:37:47PM -0500, Eric W. Biederman wrote: > > > The rest all looks good to me. Tested with and without bpf_preload patches. > > Feel free to create a frozen branch with this set. > > Can I have your Tested-by and Acked-by? For the set: Acked-by: Alexei Starovoitov Teste

Re: [PATCH v3 13/16] exit: Factor thread_group_exited out of pidfd_poll

2020-07-03 Thread Eric W. Biederman
Alexei Starovoitov writes: > On Thu, Jul 02, 2020 at 11:41:37AM -0500, Eric W. Biederman wrote: >> Create an independent helper thread_group_exited report return true >> when all threads have passed exit_notify in do_exit. AKA all of the >> threads are at least zombies and might be dead or compl

Re: [PATCH v3 13/16] exit: Factor thread_group_exited out of pidfd_poll

2020-07-03 Thread Alexei Starovoitov
On Thu, Jul 02, 2020 at 11:41:37AM -0500, Eric W. Biederman wrote: > Create an independent helper thread_group_exited report return true > when all threads have passed exit_notify in do_exit. AKA all of the > threads are at least zombies and might be dead or completely gone. > > Create this helpe

[PATCH v3 13/16] exit: Factor thread_group_exited out of pidfd_poll

2020-07-02 Thread Eric W. Biederman
Create an independent helper thread_group_exited report return true when all threads have passed exit_notify in do_exit. AKA all of the threads are at least zombies and might be dead or completely gone. Create this helper by taking the logic out of pidfd_poll where it is already tested, and addin