Re: [PATCH v3 16/16] fpga: dfl: fme: add performance reporting support

2019-06-04 Thread Wu Hao
On Sat, Jun 01, 2019 at 02:42:19AM -0700, Greg KH wrote: > On Sat, Jun 01, 2019 at 05:11:47PM +0800, Wu Hao wrote: > > On Thu, May 30, 2019 at 12:03:05PM -0700, Greg KH wrote: > > > On Mon, May 27, 2019 at 01:22:26PM +0800, Wu Hao wrote: > > > > --- /dev/null > > > > +++ b/drivers/fpga/dfl-fme-perf

Re: [PATCH v3 16/16] fpga: dfl: fme: add performance reporting support

2019-06-01 Thread Greg KH
On Sat, Jun 01, 2019 at 05:11:47PM +0800, Wu Hao wrote: > On Thu, May 30, 2019 at 12:03:05PM -0700, Greg KH wrote: > > On Mon, May 27, 2019 at 01:22:26PM +0800, Wu Hao wrote: > > > --- /dev/null > > > +++ b/drivers/fpga/dfl-fme-perf.c > > > @@ -0,0 +1,962 @@ > > > +// SPDX-License-Identifier: GPL-2

Re: [PATCH v3 16/16] fpga: dfl: fme: add performance reporting support

2019-06-01 Thread Wu Hao
On Thu, May 30, 2019 at 12:03:05PM -0700, Greg KH wrote: > On Mon, May 27, 2019 at 01:22:26PM +0800, Wu Hao wrote: > > --- /dev/null > > +++ b/drivers/fpga/dfl-fme-perf.c > > @@ -0,0 +1,962 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Driver for FPGA Management Engine (FME) Global Pe

Re: [PATCH v3 16/16] fpga: dfl: fme: add performance reporting support

2019-06-01 Thread Wu Hao
On Thu, May 30, 2019 at 01:53:23PM -0500, Alan Tull wrote: > On Mon, May 27, 2019 at 12:39 AM Wu Hao wrote: > > Hi Hao, > > Just one correction that I saw below, sorry I didn't catch it last time. Hi Alan Thanks for the review. I will remove the code below which is not used. Hao > > > > > T

Re: [PATCH v3 16/16] fpga: dfl: fme: add performance reporting support

2019-05-30 Thread Greg KH
On Mon, May 27, 2019 at 01:22:26PM +0800, Wu Hao wrote: > --- /dev/null > +++ b/drivers/fpga/dfl-fme-perf.c > @@ -0,0 +1,962 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Driver for FPGA Management Engine (FME) Global Performance Reporting > + * > + * Copyright 2019 Intel Corporation, Inc.

Re: [PATCH v3 16/16] fpga: dfl: fme: add performance reporting support

2019-05-30 Thread Alan Tull
On Mon, May 27, 2019 at 12:39 AM Wu Hao wrote: Hi Hao, Just one correction that I saw below, sorry I didn't catch it last time. > > This patch adds support for performance reporting private feature > for FPGA Management Engine (FME). Actually it supports 4 categories > performance counters, 'cl

[PATCH v3 16/16] fpga: dfl: fme: add performance reporting support

2019-05-26 Thread Wu Hao
This patch adds support for performance reporting private feature for FPGA Management Engine (FME). Actually it supports 4 categories performance counters, 'clock', 'cache', 'iommu' and 'fabric', user could read the performance counter via exposed sysfs interfaces. Please refer to sysfs doc for mor