Dear Ezequiel Garcia,
On Tue, 6 May 2014 17:53:30 -0300, Ezequiel Garcia wrote:
> > +#define USB2_PHY_CONFIG_ENABLE BIT(0) /* active low */
> > +
>
> I still think it's more readable to use USB2_PHY_CONFIG_DISABLE.
> It's just a nitpick, though.
Yes, fixed.
> > +static int armada375_usb_phy_pr
Dear Andrew Lunn,
On Tue, 6 May 2014 15:54:27 +0200, Andrew Lunn wrote:
> > +enum {
> > + PHY_USB2 = 0,
> > + PHY_USB3 = 1,
> > +};
> > +
> > +struct armada375_cluster_phy {
> > + struct phy *phy;
> > + void __iomem *reg;
> > + bool enable;
> > + bool use_usb3;
>
> Hi Gregory
>
> ni
Dear Bartlomiej Zolnierkiewicz,
On Tue, 06 May 2014 13:37:04 +0200, Bartlomiej Zolnierkiewicz wrote:
> > +config ARMADA375_USBCLUSTER_PHY
> > + def_bool y
> > + depends on OF
>
> Please limit this driver to Armada 375 or compile testing, i.e. add additional
>
> depends on (ARCH_MVEBU
Hi Greg,
On 06 May 02:14 AM, Gregory CLEMENT wrote:
> +
> +#define USB2_PHY_CONFIG_ENABLE BIT(0) /* active low */
> +
I still think it's more readable to use USB2_PHY_CONFIG_DISABLE.
It's just a nitpick, though.
> +static int armada375_usb_phy_probe(struct platform_device *pdev)
> +{
> + str
On Tue, May 06, 2014 at 02:14:12AM +0200, Gregory CLEMENT wrote:
> The Armada 375 SoC comes with an USB2 host and device controller and
> an USB3 controller. The USB cluster control register allows to manage
> common features of both USB controllers. It uses the generic PHY
> framework
>
> Signed-
Hi,
On Tuesday, May 06, 2014 02:14:12 AM Gregory CLEMENT wrote:
> The Armada 375 SoC comes with an USB2 host and device controller and
> an USB3 controller. The USB cluster control register allows to manage
> common features of both USB controllers. It uses the generic PHY
> framework
>
> Signed
The Armada 375 SoC comes with an USB2 host and device controller and
an USB3 controller. The USB cluster control register allows to manage
common features of both USB controllers. It uses the generic PHY
framework
Signed-off-by: Gregory CLEMENT
---
drivers/phy/Kconfig | 5 ++
driv
7 matches
Mail list logo
