Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 03:50:24PM +, mario.limoncie...@dell.com wrote: > And presumably that's mostly for debugging purposes and will lead > to additional quirks to get "automatic" to do the right thing on those > machines that's it's found to be needed or more beneficial. I would say that

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 03:50:24PM +, mario.limoncie...@dell.com wrote: > And presumably that's mostly for debugging purposes and will lead > to additional quirks to get "automatic" to do the right thing on those > machines that's it's found to be needed or more beneficial. I would say that

RE: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

ncie...@dell.com>; Dominguez, Jared > <jared_doming...@dell.com>; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs > > On Mon, Jun 05, 2017 at 05:20:36PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jun 05, 2017 a

RE: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

tomirski ; > Limonciello, Mario ; Dominguez, Jared > ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs > > On Mon, Jun 05, 2017 at 05:20:36PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jun 05, 2017 at 05:21:34PM +0300, An

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 05:20:36PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote: > > On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > > > > > > > It turns

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 05:20:36PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote: > > On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > > > > > > > It turns

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote: > On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > > > > It turns out that this is not too big change after all so I think it > > can > > be

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote: > On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > > > > It turns out that this is not too big change after all so I think it > > can > > be

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote: > On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > > > > It turns out that this is not too big change after all so I think it > > can > > be

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote: > On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > > > > It turns out that this is not too big change after all so I think it > > can > > be

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > It turns out that this is not too big change after all so I think it > can > be included in the ICM patch if you want. > > Basically we would have module

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > It turns out that this is not too big change after all so I think it > can > be included in the ICM patch if you want. > > Basically we would have module

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 03:46:43PM +0200, Lukas Wunner wrote: > On Mon, Jun 05, 2017 at 04:33:34PM +0300, Mika Westerberg wrote: > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > Yes, it's useful to have ICM-based Thunderbolt on Macs and personally > > > > I'm totally

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 03:46:43PM +0200, Lukas Wunner wrote: > On Mon, Jun 05, 2017 at 04:33:34PM +0300, Mika Westerberg wrote: > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > Yes, it's useful to have ICM-based Thunderbolt on Macs and personally > > > > I'm totally

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 04:33:34PM +0300, Mika Westerberg wrote: > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > Yes, it's useful to have ICM-based Thunderbolt on Macs and personally > > > I'm totally fine with making it the default for Macs which support it. > > > (I

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 04:33:34PM +0300, Mika Westerberg wrote: > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > Yes, it's useful to have ICM-based Thunderbolt on Macs and personally > > > I'm totally fine with making it the default for Macs which support it. > > > (I

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > Yes, it's useful to have ICM-based Thunderbolt on Macs and personally > > I'm totally fine with making it the default for Macs which support it. > > (I can't speak for Andreas, obviously.) > > > > However it would be great to

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > Yes, it's useful to have ICM-based Thunderbolt on Macs and personally > > I'm totally fine with making it the default for Macs which support it. > > (I can't speak for Andreas, obviously.) > > > > However it would be great to

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 02:07:56PM +0200, Lukas Wunner wrote: > On Mon, Jun 05, 2017 at 12:32:49PM +0300, Mika Westerberg wrote: > > On Mon, Jun 05, 2017 at 10:14:37AM +0200, Lukas Wunner wrote: > > > On Fri, Jun 02, 2017 at 05:05:16PM +0300, Mika Westerberg wrote: > > > > ---

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 02:07:56PM +0200, Lukas Wunner wrote: > On Mon, Jun 05, 2017 at 12:32:49PM +0300, Mika Westerberg wrote: > > On Mon, Jun 05, 2017 at 10:14:37AM +0200, Lukas Wunner wrote: > > > On Fri, Jun 02, 2017 at 05:05:16PM +0300, Mika Westerberg wrote: > > > > ---

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 12:32:49PM +0300, Mika Westerberg wrote: > On Mon, Jun 05, 2017 at 10:14:37AM +0200, Lukas Wunner wrote: > > On Fri, Jun 02, 2017 at 05:05:16PM +0300, Mika Westerberg wrote: > > > --- a/drivers/thunderbolt/nhi.h > > > +++ b/drivers/thunderbolt/nhi.h > > > @@ -143,4 +143,21

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 12:32:49PM +0300, Mika Westerberg wrote: > On Mon, Jun 05, 2017 at 10:14:37AM +0200, Lukas Wunner wrote: > > On Fri, Jun 02, 2017 at 05:05:16PM +0300, Mika Westerberg wrote: > > > --- a/drivers/thunderbolt/nhi.h > > > +++ b/drivers/thunderbolt/nhi.h > > > @@ -143,4 +143,21

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 10:14:37AM +0200, Lukas Wunner wrote: > On Fri, Jun 02, 2017 at 05:05:16PM +0300, Mika Westerberg wrote: > > --- a/drivers/thunderbolt/nhi.h > > +++ b/drivers/thunderbolt/nhi.h > > @@ -143,4 +143,21 @@ static inline int ring_tx(struct tb_ring *ring, struct > > ring_frame

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Mon, Jun 05, 2017 at 10:14:37AM +0200, Lukas Wunner wrote: > On Fri, Jun 02, 2017 at 05:05:16PM +0300, Mika Westerberg wrote: > > --- a/drivers/thunderbolt/nhi.h > > +++ b/drivers/thunderbolt/nhi.h > > @@ -143,4 +143,21 @@ static inline int ring_tx(struct tb_ring *ring, struct > > ring_frame

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Fri, Jun 02, 2017 at 05:05:16PM +0300, Mika Westerberg wrote: > --- a/drivers/thunderbolt/nhi.h > +++ b/drivers/thunderbolt/nhi.h > @@ -143,4 +143,21 @@ static inline int ring_tx(struct tb_ring *ring, struct > ring_frame *frame) > return __ring_enqueue(ring, frame); > } > > +/* > + *

Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

On Fri, Jun 02, 2017 at 05:05:16PM +0300, Mika Westerberg wrote: > --- a/drivers/thunderbolt/nhi.h > +++ b/drivers/thunderbolt/nhi.h > @@ -143,4 +143,21 @@ static inline int ring_tx(struct tb_ring *ring, struct > ring_frame *frame) > return __ring_enqueue(ring, frame); > } > > +/* > + *

[PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

Add Intel Win Ridge (Thunderbolt 2) and Alpine Ridge (Thunderbolt 3) controller PCI IDs to the list of supported devices. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg

[PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs

Add Intel Win Ridge (Thunderbolt 2) and Alpine Ridge (Thunderbolt 3) controller PCI IDs to the list of supported devices. This code is based on the work done by Amir Levy and Michael Jamet. Signed-off-by: Michael Jamet Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Reviewed-by: