Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-28 Thread Leonard Crestez
On Wed, 2018-11-28 at 18:36 +0100, Stefan Agner wrote: > On 28.11.2018 13:19, Stefan Agner wrote: > > On 21.11.2018 14:47, Leonard Crestez wrote: > > > My tests show that this series breaks pci cards on 6qdl and I > > > think it should be reverted until a fix is found. Are you OK with > > > this? >

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-28 Thread Stefan Agner
On 28.11.2018 18:50, Lucas Stach wrote: > Am Mittwoch, den 28.11.2018, 18:36 +0100 schrieb Stefan Agner: >> On 28.11.2018 13:19, Stefan Agner wrote: >> > On 21.11.2018 14:47, Leonard Crestez wrote: >> > > On 11/20/2018 11:28 PM, Trent Piepho wrote: >> > > > On Tue, 2018-11-20 at 21:42 +0100, Stefan

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-28 Thread Lucas Stach
Am Mittwoch, den 28.11.2018, 18:36 +0100 schrieb Stefan Agner: > On 28.11.2018 13:19, Stefan Agner wrote: > > On 21.11.2018 14:47, Leonard Crestez wrote: > > > On 11/20/2018 11:28 PM, Trent Piepho wrote: > > > > On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: > > > > > On 20.11.2018 20:13, T

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-28 Thread Stefan Agner
On 28.11.2018 13:19, Stefan Agner wrote: > On 21.11.2018 14:47, Leonard Crestez wrote: >> On 11/20/2018 11:28 PM, Trent Piepho wrote: >>> On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: On 20.11.2018 20:13, Trent Piepho wrote: >> > It also seems to me that this doesn't need to be in

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-28 Thread Stefan Agner
On 21.11.2018 14:47, Leonard Crestez wrote: > On 11/20/2018 11:28 PM, Trent Piepho wrote: >> On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: >>> On 20.11.2018 20:13, Trent Piepho wrote: > It also seems to me that this doesn't need to be in the internal pci config access functions.

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-26 Thread Trent Piepho
On Mon, 2018-11-26 at 10:16 +, Leonard Crestez wrote: > On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: > > On 20.11.2018 20:13, Trent Piepho wrote: > > > On Tue, 2018-11-20 at 18:19 +, Leonard Crestez wrote: > > > > On Tue, 2018-11-20 at 17:56 +0100, Stefan Agner wrote: > > > > > De

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-26 Thread Leonard Crestez
On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: > On 20.11.2018 20:13, Trent Piepho wrote: > > On Tue, 2018-11-20 at 18:19 +, Leonard Crestez wrote: > > > On Tue, 2018-11-20 at 17:56 +0100, Stefan Agner wrote: > > > > Define the length of the DBI registers. This makes sure that > > > > t

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-21 Thread Lorenzo Pieralisi
On Wed, Nov 21, 2018 at 01:47:05PM +, Leonard Crestez wrote: > On 11/20/2018 11:28 PM, Trent Piepho wrote: > > On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: > >> On 20.11.2018 20:13, Trent Piepho wrote: > > >>> It also seems to me that this doesn't need to be in the internal pci > >>>

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-21 Thread Leonard Crestez
On 11/20/2018 11:28 PM, Trent Piepho wrote: > On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: >> On 20.11.2018 20:13, Trent Piepho wrote: >>> It also seems to me that this doesn't need to be in the internal pci >>> config access functions. The driver shouldn't be reading registers >>> that

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-20 Thread Trent Piepho
On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote: > On 20.11.2018 20:13, Trent Piepho wrote: > > > > On IMX7d, there are significant blocks of 00s in the config space, and > > all 0xff at 0xb50 on up. > > > > I.e., significant portions are empty, in the middle of the config > > space, not ju

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-20 Thread Stefan Agner
On 20.11.2018 20:13, Trent Piepho wrote: > On Tue, 2018-11-20 at 18:19 +, Leonard Crestez wrote: >> On Tue, 2018-11-20 at 17:56 +0100, Stefan Agner wrote: >> > Define the length of the DBI registers. This makes sure that >> > the kernel does not access registers beyond that point, avoiding >> >

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-20 Thread Trent Piepho
On Tue, 2018-11-20 at 18:19 +, Leonard Crestez wrote: > On Tue, 2018-11-20 at 17:56 +0100, Stefan Agner wrote: > > Define the length of the DBI registers. This makes sure that > > the kernel does not access registers beyond that point, avoiding > > the following abort on a i.MX 6Quad: > > # c

Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-20 Thread Leonard Crestez
On Tue, 2018-11-20 at 17:56 +0100, Stefan Agner wrote: > Define the length of the DBI registers. This makes sure that > the kernel does not access registers beyond that point, avoiding > the following abort on a i.MX 6Quad: > # cat > /sys/devices/soc0/soc/1ffc000.pcie/pci\:00/\:00\:00.0/c

[PATCH v3 2/2] PCI: imx6: limit DBI register length

2018-11-20 Thread Stefan Agner
Define the length of the DBI registers. This makes sure that the kernel does not access registers beyond that point, avoiding the following abort on a i.MX 6Quad: # cat /sys/devices/soc0/soc/1ffc000.pcie/pci\:00/\:00\:00.0/config [ 100.021433] Unhandled fault: imprecise external abort