Re: [Xen-devel] [PATCH v3 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-12-08 Thread Julien Grall
Hi Royger, On 01/12/15 15:30, Roger Pau Monné wrote: > Just a couple of cosmetic comments below. Unless anyone else has real > comments I don't think you need to resend. Well, I'm considering those kind of comestic comments as minor. They are not necessary and doesn't improve the readability of t

Re: [PATCH v3 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-12-01 Thread Roger Pau Monné
El 18/11/15 a les 19.57, Julien Grall ha escrit: > The minimal size of request in the block framework is always PAGE_SIZE. > It means that when 64KB guest is support, the request will at least be > 64KB. > > Although, if the backend doesn't support indirect descriptor (such as QDISK > in QEMU), a

[PATCH v3 2/2] block/xen-blkfront: Handle non-indirect grant with 64KB pages

2015-11-18 Thread Julien Grall
The minimal size of request in the block framework is always PAGE_SIZE. It means that when 64KB guest is support, the request will at least be 64KB. Although, if the backend doesn't support indirect descriptor (such as QDISK in QEMU), a ring request is only able to accommodate 11 segments of 4KB (