Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Alexandre Belloni
On 24/08/2015 at 11:18:19 +0200, Michal Simek wrote : > > I'm not fond of carrying patches with uncontactable authors. Is that a > > permanent error? > > Unfortunately. That guy left Xilinx last week but don't be scared that > none will be responsible about this driver. I have well proven history

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Michal Simek
Hi, On 08/24/2015 10:08 AM, Alexandre Belloni wrote: > On 24/08/2015 at 09:48:42 +0200, Michal Simek wrote : >> On 08/24/2015 09:43 AM, Alexandre Belloni wrote: >>> On 19/08/2015 at 15:23:22 +0530, Suneel Garapati wrote : adds support for RTC controller found on Xilinx Zynq Ultrascale+

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Alexandre Belloni
On 24/08/2015 at 09:48:42 +0200, Michal Simek wrote : > On 08/24/2015 09:43 AM, Alexandre Belloni wrote: > > On 19/08/2015 at 15:23:22 +0530, Suneel Garapati wrote : > >> adds support for RTC controller found on > >> Xilinx Zynq Ultrascale+ MPSoC platform. > >> > >> Signed-off-by: Suneel Garapati

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Michal Simek
On 08/24/2015 09:43 AM, Alexandre Belloni wrote: > On 19/08/2015 at 15:23:22 +0530, Suneel Garapati wrote : >> adds support for RTC controller found on >> Xilinx Zynq Ultrascale+ MPSoC platform. >> >> Signed-off-by: Suneel Garapati >> --- >> Changes v3 >> - fix checkpatch errors >> - check time

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Alexandre Belloni
On 19/08/2015 at 15:23:22 +0530, Suneel Garapati wrote : > adds support for RTC controller found on > Xilinx Zynq Ultrascale+ MPSoC platform. > > Signed-off-by: Suneel Garapati > --- > Changes v3 > - fix checkpatch errors > - check time in secs arg against max sec val > - order header files

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Alexandre Belloni
On 19/08/2015 at 15:23:22 +0530, Suneel Garapati wrote : adds support for RTC controller found on Xilinx Zynq Ultrascale+ MPSoC platform. Signed-off-by: Suneel Garapati suneel.garap...@xilinx.com --- Changes v3 - fix checkpatch errors - check time in secs arg against max sec val -

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Alexandre Belloni
On 24/08/2015 at 09:48:42 +0200, Michal Simek wrote : On 08/24/2015 09:43 AM, Alexandre Belloni wrote: On 19/08/2015 at 15:23:22 +0530, Suneel Garapati wrote : adds support for RTC controller found on Xilinx Zynq Ultrascale+ MPSoC platform. Signed-off-by: Suneel Garapati

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Michal Simek
On 08/24/2015 09:43 AM, Alexandre Belloni wrote: On 19/08/2015 at 15:23:22 +0530, Suneel Garapati wrote : adds support for RTC controller found on Xilinx Zynq Ultrascale+ MPSoC platform. Signed-off-by: Suneel Garapati suneel.garap...@xilinx.com --- Changes v3 - fix checkpatch errors -

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Alexandre Belloni
On 24/08/2015 at 11:18:19 +0200, Michal Simek wrote : I'm not fond of carrying patches with uncontactable authors. Is that a permanent error? Unfortunately. That guy left Xilinx last week but don't be scared that none will be responsible about this driver. I have well proven history on

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-24 Thread Michal Simek
Hi, On 08/24/2015 10:08 AM, Alexandre Belloni wrote: On 24/08/2015 at 09:48:42 +0200, Michal Simek wrote : On 08/24/2015 09:43 AM, Alexandre Belloni wrote: On 19/08/2015 at 15:23:22 +0530, Suneel Garapati wrote : adds support for RTC controller found on Xilinx Zynq Ultrascale+ MPSoC

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-20 Thread Moritz Fischer
Hi Suneel On Wed, Aug 19, 2015 at 9:37 PM, wrote: > Hi Moritz, > > devm_ioremap_resource validates the argument pointer of struct resource. > Hence no explicit validation of return value of platform_get_resource > function. > It seems to be common practice with all other drivers in drivers/rtc.

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-20 Thread Moritz Fischer
Hi Suneel On Wed, Aug 19, 2015 at 9:37 PM, suneelgarap...@gmail.com wrote: Hi Moritz, devm_ioremap_resource validates the argument pointer of struct resource. Hence no explicit validation of return value of platform_get_resource function. It seems to be common practice with all other

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-19 Thread Moritz Fischer
Hi Suneel, looks good, minor nit below. On Wed, Aug 19, 2015 at 2:53 AM, Suneel Garapati wrote: > adds support for RTC controller found on > Xilinx Zynq Ultrascale+ MPSoC platform. > > Signed-off-by: Suneel Garapati > --- > Changes v3 > - fix checkpatch errors > - check time in secs arg

[PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-19 Thread Suneel Garapati
adds support for RTC controller found on Xilinx Zynq Ultrascale+ MPSoC platform. Signed-off-by: Suneel Garapati --- Changes v3 - fix checkpatch errors - check time in secs arg against max sec val - order header files - use ptr_err_or_zero macro - use time64 variants Changes v2 - change

Re: [PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-19 Thread Moritz Fischer
Hi Suneel, looks good, minor nit below. On Wed, Aug 19, 2015 at 2:53 AM, Suneel Garapati suneel.garap...@xilinx.com wrote: adds support for RTC controller found on Xilinx Zynq Ultrascale+ MPSoC platform. Signed-off-by: Suneel Garapati suneel.garap...@xilinx.com --- Changes v3 - fix

[PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-19 Thread Suneel Garapati
adds support for RTC controller found on Xilinx Zynq Ultrascale+ MPSoC platform. Signed-off-by: Suneel Garapati suneel.garap...@xilinx.com --- Changes v3 - fix checkpatch errors - check time in secs arg against max sec val - order header files - use ptr_err_or_zero macro - use time64

[PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-14 Thread Suneel Garapati
adds support for RTC controller found on Xilinx Zynq Ultrascale+ MPSoC platform. Signed-off-by: Suneel Garapati --- Changes v3 - fix checkpatch errors - check time in secs arg against max sec val - order header files - use ptr_err_or_zero macro - use time64 variants Changes v2 - change

[PATCH v3 2/2] drivers: rtc: add xilinx zynqmp rtc driver

2015-08-14 Thread Suneel Garapati
adds support for RTC controller found on Xilinx Zynq Ultrascale+ MPSoC platform. Signed-off-by: Suneel Garapati suneel.garap...@xilinx.com --- Changes v3 - fix checkpatch errors - check time in secs arg against max sec val - order header files - use ptr_err_or_zero macro - use time64