Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi, On 4.04.2018 20:30, risha...@codeaurora.org wrote: Hi Stanimir, We incorporated all your comments except the following: 1. Removing the driver that maintains the SCT (system cache table) per chipset. As responded earlier the data is expected to change from chipset to chipset and would

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi, On 4.04.2018 20:30, risha...@codeaurora.org wrote: Hi Stanimir, We incorporated all your comments except the following: 1. Removing the driver that maintains the SCT (system cache table) per chipset. As responded earlier the data is expected to change from chipset to chipset and would

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi Stanimir, We incorporated all your comments except the following: 1. Removing the driver that maintains the SCT (system cache table) per chipset. As responded earlier the data is expected to change from chipset to chipset and would clutter the main driver if we choose using compatible string.

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi Stanimir, We incorporated all your comments except the following: 1. Removing the driver that maintains the SCT (system cache table) per chipset. As responded earlier the data is expected to change from chipset to chipset and would clutter the main driver if we choose using compatible string.

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

On 2018-04-02 02:11, Stanimir Varbanov wrote: Hi, Please adjust your mail client to drop on new line on 80 column! On 03/29/2018 08:55 PM, Channa wrote: On 2018-03-29 01:08, Stanimir Varbanov wrote: Hi, On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: LLCC (Last Level Cache Controller)

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

On 2018-04-02 02:11, Stanimir Varbanov wrote: Hi, Please adjust your mail client to drop on new line on 80 column! On 03/29/2018 08:55 PM, Channa wrote: On 2018-03-29 01:08, Stanimir Varbanov wrote: Hi, On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: LLCC (Last Level Cache Controller)

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi, Please adjust your mail client to drop on new line on 80 column! On 03/29/2018 08:55 PM, Channa wrote: > On 2018-03-29 01:08, Stanimir Varbanov wrote: >> Hi, >> >> On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: >>> LLCC (Last Level Cache Controller) provides additional cache memory >>> in

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi, Please adjust your mail client to drop on new line on 80 column! On 03/29/2018 08:55 PM, Channa wrote: > On 2018-03-29 01:08, Stanimir Varbanov wrote: >> Hi, >> >> On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: >>> LLCC (Last Level Cache Controller) provides additional cache memory >>> in

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi Stanimir, +/* Get the slice entry by index */ +static struct llcc_slice_desc *llcc_slice_get_entry(struct device *dev, int n) drop this *slice* word from function names Please note that we are activating/de-activating  a "slice" of the LLCC and not a whole LLCC. "slice" makes perfect

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi Stanimir, +/* Get the slice entry by index */ +static struct llcc_slice_desc *llcc_slice_get_entry(struct device *dev, int n) drop this *slice* word from function names Please note that we are activating/de-activating  a "slice" of the LLCC and not a whole LLCC. "slice" makes perfect

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

On 2018-03-29 01:08, Stanimir Varbanov wrote: Hi, On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into muliple slices and each slice getting its own priority, size, ID and other config

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

On 2018-03-29 01:08, Stanimir Varbanov wrote: Hi, On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into muliple slices and each slice getting its own priority, size, ID and other config

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi, On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: > LLCC (Last Level Cache Controller) provides additional cache memory > in the system. LLCC is partitioned into muliple slices and each > slice getting its own priority, size, ID and other config parameters. > LLCC driver programs these

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi, On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: > LLCC (Last Level Cache Controller) provides additional cache memory > in the system. LLCC is partitioned into muliple slices and each > slice getting its own priority, size, ID and other config parameters. > LLCC driver programs these

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi Rishabh, On Tue, Mar 27, 2018 at 11:54 AM Rishabh Bhatnagar wrote: > LLCC (Last Level Cache Controller) provides additional cache memory > in the system. LLCC is partitioned into muliple slices and each > slice getting its own priority, size, ID and other config

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

Hi Rishabh, On Tue, Mar 27, 2018 at 11:54 AM Rishabh Bhatnagar wrote: > LLCC (Last Level Cache Controller) provides additional cache memory > in the system. LLCC is partitioned into muliple slices and each > slice getting its own priority, size, ID and other config parameters. > LLCC driver

[PATCH v3 2/2] drivers: soc: Add LLCC driver

LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into muliple slices and each slice getting its own priority, size, ID and other config parameters. LLCC driver programs these parameters for each slice. Clients that are assigned to use LLCC need

[PATCH v3 2/2] drivers: soc: Add LLCC driver

LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into muliple slices and each slice getting its own priority, size, ID and other config parameters. LLCC driver programs these parameters for each slice. Clients that are assigned to use LLCC need