Re: [PATCH v3 2/2] ksm: provide support to use deferrable timers for scanner thread

2014-08-20 Thread Chintan Pandya
Hi Hugh, + unsigned long enable; + int err; + + err = kstrtoul(buf, 10,&enable); + if (err< 0) + return err; + if (enable>= 1) + return -EINVAL; I haven't studied the patch itself, I'm still worrying about the concept. But this caught my eye just before hitting Send: I don't think we need a tu

Re: [PATCH v3 2/2] ksm: provide support to use deferrable timers for scanner thread

2014-08-12 Thread Chintan Pandya
Hi Hugh, Typically, on our setup we observed, 10% less power consumption with some use-cases in which CPU goes to power collapse frequently. For example, playing audio while typically CPU remains idle. I'm probably stupid, but I don't quite get your scenario from that description: please wou

Re: [PATCH v3 2/2] ksm: provide support to use deferrable timers for scanner thread

2014-08-11 Thread Hugh Dickins
On Thu, 31 Jul 2014, Chintan Pandya wrote: > KSM thread to scan pages is scheduled on definite timeout. That wakes up > CPU from idle state and hence may affect the power consumption. Provide > an optional support to use deferrable timer which suites low-power > use-cases. Thanks for drawing at

[PATCH v3 2/2] ksm: provide support to use deferrable timers for scanner thread

2014-07-31 Thread Chintan Pandya
KSM thread to scan pages is scheduled on definite timeout. That wakes up CPU from idle state and hence may affect the power consumption. Provide an optional support to use deferrable timer which suites low-power use-cases. Typically, on our setup we observed, 10% less power consumption with some