Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-30 Thread Jacek Anaszewski
Hi Florian, On 09/29/2016 06:18 PM, Florian Vaussard wrote: Hi Jacek, Thank you for your comments! Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : Hi Florian, Thanks for the updated patch set. I have few comments below. On 09/16/2016 01:34 PM, Florian Vaussard wrote: The NCP5623 is a

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-30 Thread Jacek Anaszewski
Hi Florian, On 09/29/2016 06:18 PM, Florian Vaussard wrote: Hi Jacek, Thank you for your comments! Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : Hi Florian, Thanks for the updated patch set. I have few comments below. On 09/16/2016 01:34 PM, Florian Vaussard wrote: The NCP5623 is a

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-29 Thread Florian Vaussard
Replying to my self after thinking twice... Le 29. 09. 16 à 18:18, Florian Vaussard a écrit : > Hi Jacek, > > Thank you for your comments! > > Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : >> Hi Florian, >> >> Thanks for the updated patch set. I have few comments below. >> >> On 09/16/2016

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-29 Thread Florian Vaussard
Replying to my self after thinking twice... Le 29. 09. 16 à 18:18, Florian Vaussard a écrit : > Hi Jacek, > > Thank you for your comments! > > Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : >> Hi Florian, >> >> Thanks for the updated patch set. I have few comments below. >> >> On 09/16/2016

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-29 Thread Florian Vaussard
Hi Jacek, Thank you for your comments! Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : > Hi Florian, > > Thanks for the updated patch set. I have few comments below. > > On 09/16/2016 01:34 PM, Florian Vaussard wrote: >> The NCP5623 is a 3-channel LED driver from On Semiconductor controlled

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-29 Thread Florian Vaussard
Hi Jacek, Thank you for your comments! Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : > Hi Florian, > > Thanks for the updated patch set. I have few comments below. > > On 09/16/2016 01:34 PM, Florian Vaussard wrote: >> The NCP5623 is a 3-channel LED driver from On Semiconductor controlled

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-24 Thread Jacek Anaszewski
On 09/24/2016 02:00 PM, Pavel Machek wrote: Hi! Instead I propose the following: n_iled_max = 31 - (priv->led_iref * 2400 / priv->leds_max_current + !!(priv->led_iref * 2400 % priv->leds_max_current)) div_round_up? Exactly. Thanks. -- Best regards, Jacek Anaszewski

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-24 Thread Jacek Anaszewski
On 09/24/2016 02:00 PM, Pavel Machek wrote: Hi! Instead I propose the following: n_iled_max = 31 - (priv->led_iref * 2400 / priv->leds_max_current + !!(priv->led_iref * 2400 % priv->leds_max_current)) div_round_up? Exactly. Thanks. -- Best regards, Jacek Anaszewski

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-24 Thread Pavel Machek
Hi! > Instead I propose the following: > > n_iled_max = > 31 - (priv->led_iref * 2400 / priv->leds_max_current + >!!(priv->led_iref * 2400 % priv->leds_max_current)) > div_round_up? Best regards, Pavel --

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-24 Thread Pavel Machek
Hi! > Instead I propose the following: > > n_iled_max = > 31 - (priv->led_iref * 2400 / priv->leds_max_current + >!!(priv->led_iref * 2400 % priv->leds_max_current)) > div_round_up? Best regards, Pavel --

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-18 Thread Jacek Anaszewski
Hi Florian, Thanks for the updated patch set. I have few comments below. On 09/16/2016 01:34 PM, Florian Vaussard wrote: The NCP5623 is a 3-channel LED driver from On Semiconductor controlled through I2C. The PWM of each channel can be independently set with 32 distinct levels. In addition,

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-18 Thread Jacek Anaszewski
Hi Florian, Thanks for the updated patch set. I have few comments below. On 09/16/2016 01:34 PM, Florian Vaussard wrote: The NCP5623 is a 3-channel LED driver from On Semiconductor controlled through I2C. The PWM of each channel can be independently set with 32 distinct levels. In addition,

[PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-16 Thread Florian Vaussard
The NCP5623 is a 3-channel LED driver from On Semiconductor controlled through I2C. The PWM of each channel can be independently set with 32 distinct levels. In addition, the intensity of the current source can be globally set using an external bias resistor fixing the reference current (Iref) and

[PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-16 Thread Florian Vaussard
The NCP5623 is a 3-channel LED driver from On Semiconductor controlled through I2C. The PWM of each channel can be independently set with 32 distinct levels. In addition, the intensity of the current source can be globally set using an external bias resistor fixing the reference current (Iref) and