Re: [PATCH v3 2/2] leds: add Panasonic AN30259A support

2018-07-27 Thread Jacek Anaszewski
On 07/27/2018 10:08 PM, Jacek Anaszewski wrote: Hi Simon, Thank you for the updated patch. It looks good in general, with one reservation, please refer below. And one more issue: drivers/leds/leds-an30259a.c: In function 'an30259a_blink_set': drivers/leds/leds-an30259a.c:129:23: warning: unus

Re: [PATCH v3 2/2] leds: add Panasonic AN30259A support

2018-07-27 Thread Jacek Anaszewski
Hi Simon, Thank you for the updated patch. It looks good in general, with one reservation, please refer below. On 07/21/2018 04:12 PM, Simon Shields wrote: AN30259A is a 3-channel LED driver which uses I2C. It supports timed operation via an internal PWM clock, and variable brightness. This dri

Re: [PATCH v3 2/2] leds: add Panasonic AN30259A support

2018-07-26 Thread Pavel Machek
On Sun 2018-07-22 00:12:27, Simon Shields wrote: > AN30259A is a 3-channel LED driver which uses I2C. It supports timed > operation via an internal PWM clock, and variable brightness. This > driver offers support for basic hardware-based blinking and brightness > control. > > The datasheet is free

[PATCH v3 2/2] leds: add Panasonic AN30259A support

2018-07-21 Thread Simon Shields
AN30259A is a 3-channel LED driver which uses I2C. It supports timed operation via an internal PWM clock, and variable brightness. This driver offers support for basic hardware-based blinking and brightness control. The datasheet is freely available: https://www.alliedelec.com/m/d/a9d2b3ee87c2d1a5