Re: [PATCH v3 2/2] max77693: added device tree support

2013-09-27 Thread Lee Jones
On Wed, 21 Aug 2013, Andrzej Hajda wrote: > This patch adds only of_match_table. > There are no device specific properties. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- > drivers/mfd/max77693.c | 8 > 1 file changed, 8

Re: [PATCH v3 2/2] max77693: added device tree support

2013-09-27 Thread Lee Jones
On Wed, 21 Aug 2013, Andrzej Hajda wrote: This patch adds only of_match_table. There are no device specific properties. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v3 2/2] max77693: added device tree support

2013-09-26 Thread Andrzej Hajda
On 08/21/2013 06:53 PM, Andrzej Hajda wrote: > This patch adds only of_match_table. > There are no device specific properties. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- > drivers/mfd/max77693.c | 8 > 1 file changed, 8

Re: [PATCH v3 2/2] max77693: added device tree support

2013-09-26 Thread Andrzej Hajda
On 08/21/2013 06:53 PM, Andrzej Hajda wrote: This patch adds only of_match_table. There are no device specific properties. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v3 2/2] max77693: added device tree support

2013-09-06 Thread Mark Brown
On Fri, Aug 23, 2013 at 10:08:39PM +0200, Tomasz Figa wrote: > On Wednesday 21 of August 2013 18:53:34 Andrzej Hajda wrote: > > +#ifdef CONFIG_OF > > +static struct of_device_id max77693_dt_match[] = { > > + {.compatible = "maxim,max77693"}, > > + {}, > > +}; > > +#endif > As far as I'm

Re: [PATCH v3 2/2] max77693: added device tree support

2013-09-06 Thread Mark Brown
On Fri, Aug 23, 2013 at 10:08:39PM +0200, Tomasz Figa wrote: On Wednesday 21 of August 2013 18:53:34 Andrzej Hajda wrote: +#ifdef CONFIG_OF +static struct of_device_id max77693_dt_match[] = { + {.compatible = maxim,max77693}, + {}, +}; +#endif As far as I'm aware of, you don't

Re: [PATCH v3 2/2] max77693: added device tree support

2013-08-23 Thread Tomasz Figa
Hi Mark, On Friday 23 of August 2013 15:14:33 Mark Rutland wrote: > On Wed, Aug 21, 2013 at 05:53:34PM +0100, Andrzej Hajda wrote: > > This patch adds only of_match_table. > > There are no device specific properties. > > Could you clarify what functionality this enables and what it doesn't, >

Re: [PATCH v3 2/2] max77693: added device tree support

2013-08-23 Thread Tomasz Figa
Hi Andrzej, On Wednesday 21 of August 2013 18:53:34 Andrzej Hajda wrote: > This patch adds only of_match_table. > There are no device specific properties. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- > drivers/mfd/max77693.c | 8

Re: [PATCH v3 2/2] max77693: added device tree support

2013-08-23 Thread Mark Rutland
On Wed, Aug 21, 2013 at 05:53:34PM +0100, Andrzej Hajda wrote: > This patch adds only of_match_table. > There are no device specific properties. Could you clarify what functionality this enables and what it doesn't, please? This doesn't seem to enable support for the regulators described in the

Re: [PATCH v3 2/2] max77693: added device tree support

2013-08-23 Thread Mark Rutland
On Wed, Aug 21, 2013 at 05:53:34PM +0100, Andrzej Hajda wrote: This patch adds only of_match_table. There are no device specific properties. Could you clarify what functionality this enables and what it doesn't, please? This doesn't seem to enable support for the regulators described in the

Re: [PATCH v3 2/2] max77693: added device tree support

2013-08-23 Thread Tomasz Figa
Hi Andrzej, On Wednesday 21 of August 2013 18:53:34 Andrzej Hajda wrote: This patch adds only of_match_table. There are no device specific properties. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH v3 2/2] max77693: added device tree support

2013-08-23 Thread Tomasz Figa
Hi Mark, On Friday 23 of August 2013 15:14:33 Mark Rutland wrote: On Wed, Aug 21, 2013 at 05:53:34PM +0100, Andrzej Hajda wrote: This patch adds only of_match_table. There are no device specific properties. Could you clarify what functionality this enables and what it doesn't, please?

[PATCH v3 2/2] max77693: added device tree support

2013-08-21 Thread Andrzej Hajda
This patch adds only of_match_table. There are no device specific properties. Signed-off-by: Andrzej Hajda Reviewed-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/mfd/max77693.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/mfd/max77693.c

[PATCH v3 2/2] max77693: added device tree support

2013-08-21 Thread Andrzej Hajda
This patch adds only of_match_table. There are no device specific properties. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/mfd/max77693.c | 8 1 file changed, 8