Re: [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-14 Thread Jernej Škrabec
Dne ponedeljek, 11. februar 2019 ob 15:39:03 CET je Maxime Ripard napisal(a): > Introduce some basic H264 decoding support in cedrus. So far, only the > baseline profile videos have been tested, and some more advanced features > used in higher profiles are not even implemented. > > Signed-off-by:

Re: [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-14 Thread Jernej Škrabec
Dne ponedeljek, 11. februar 2019 ob 15:39:03 CET je Maxime Ripard napisal(a): > Introduce some basic H264 decoding support in cedrus. So far, only the > baseline profile videos have been tested, and some more advanced features > used in higher profiles are not even implemented. > > Signed-off-by:

Re: [linux-sunxi] [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Jernej Škrabec
Dne torek, 12. februar 2019 ob 11:43:14 CET je Maxime Ripard napisal(a): > Hi, > > On Mon, Feb 11, 2019 at 08:21:31PM +0100, Jernej Škrabec wrote: > > > + reg = 0; > > > + /* > > > + * FIXME: This bit tells the video engine to use the default > > > + * quantization matrices. This will obviously

Re: [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Jernej Škrabec
Dne torek, 12. februar 2019 ob 13:47:13 CET je Maxime Ripard napisal(a): > On Mon, Feb 11, 2019 at 04:48:17PM -0300, Ezequiel Garcia wrote: > > On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote: > > > Introduce some basic H264 decoding support in cedrus. So far, only the > > > baseline

Re: [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Maxime Ripard
On Mon, Feb 11, 2019 at 04:48:17PM -0300, Ezequiel Garcia wrote: > On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote: > > Introduce some basic H264 decoding support in cedrus. So far, only the > > baseline profile videos have been tested, and some more advanced features > > used in higher

Re: [linux-sunxi] [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Maxime Ripard
Hi, On Mon, Feb 11, 2019 at 08:21:31PM +0100, Jernej Škrabec wrote: > > + reg = 0; > > + /* > > +* FIXME: This bit tells the video engine to use the default > > +* quantization matrices. This will obviously need to be > > +* changed to support the profiles supporting custom > > +

Re: [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-11 Thread Ezequiel Garcia
On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote: > Introduce some basic H264 decoding support in cedrus. So far, only the > baseline profile videos have been tested, and some more advanced features > used in higher profiles are not even implemented. > > Signed-off-by: Maxime Ripard [..]

Re: [linux-sunxi] [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-11 Thread Jernej Škrabec
Hi Maxime, I spotted few minor issues, but otherwise it looks very well. I'll do detailed review at a later time. Dne ponedeljek, 11. februar 2019 ob 15:39:03 CET je Maxime Ripard napisal(a): > Introduce some basic H264 decoding support in cedrus. So far, only the > baseline profile videos

[PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-11 Thread Maxime Ripard
Introduce some basic H264 decoding support in cedrus. So far, only the baseline profile videos have been tested, and some more advanced features used in higher profiles are not even implemented. Signed-off-by: Maxime Ripard --- drivers/staging/media/sunxi/cedrus/Makefile | 3 +-