Re: [PATCH v3 2/2] media: mtk-vcodec: fix build breakage when one of VPU or SCP is enabled

2020-10-13 Thread Alexandre Courbot
Hi Mauro, On Mon, Oct 12, 2020 at 4:43 PM Mauro Carvalho Chehab wrote: > > Em Mon, 12 Oct 2020 14:35:57 +0900 > Alexandre Courbot escreveu: > > > The addition of MT8183 support added a dependency on the SCP remoteproc > > module. However the initial patch used the "select" Kconfig directive, >

Re: [PATCH v3 2/2] media: mtk-vcodec: fix build breakage when one of VPU or SCP is enabled

2020-10-12 Thread Alexandre Courbot
On Tue, Oct 13, 2020 at 12:00 AM Randy Dunlap wrote: > > On 10/11/20 10:35 PM, Alexandre Courbot wrote: > > The addition of MT8183 support added a dependency on the SCP remoteproc > > module. However the initial patch used the "select" Kconfig directive, > > which may result in the SCP module to

Re: [PATCH v3 2/2] media: mtk-vcodec: fix build breakage when one of VPU or SCP is enabled

2020-10-12 Thread Randy Dunlap
Hi, For the Kconfig entries, specifically the help text: On 10/11/20 10:35 PM, Alexandre Courbot wrote: > --- > drivers/media/platform/Kconfig| 22 +++ > drivers/media/platform/mtk-vcodec/Makefile| 10 +++-- > .../platform/mtk-vcodec/mtk_vcodec_fw_priv.h

Re: [PATCH v3 2/2] media: mtk-vcodec: fix build breakage when one of VPU or SCP is enabled

2020-10-12 Thread Randy Dunlap
On 10/11/20 10:35 PM, Alexandre Courbot wrote: > The addition of MT8183 support added a dependency on the SCP remoteproc > module. However the initial patch used the "select" Kconfig directive, > which may result in the SCP module to not be compiled if remoteproc was > disabled. In such a case,

Re: [PATCH v3 2/2] media: mtk-vcodec: fix build breakage when one of VPU or SCP is enabled

2020-10-12 Thread Mauro Carvalho Chehab
Em Mon, 12 Oct 2020 14:35:57 +0900 Alexandre Courbot escreveu: > The addition of MT8183 support added a dependency on the SCP remoteproc > module. However the initial patch used the "select" Kconfig directive, > which may result in the SCP module to not be compiled if remoteproc was > disabled.

[PATCH v3 2/2] media: mtk-vcodec: fix build breakage when one of VPU or SCP is enabled

2020-10-11 Thread Alexandre Courbot
The addition of MT8183 support added a dependency on the SCP remoteproc module. However the initial patch used the "select" Kconfig directive, which may result in the SCP module to not be compiled if remoteproc was disabled. In such a case, mtk-vcodec would try to link against non-existent SCP