Re: [PATCH v3 2/2] mm/page_alloc: fix memmap_init_zone pageblock alignment

2018-03-13 Thread Daniel Vacek
On Tue, Mar 13, 2018 at 7:34 AM, Naresh Kamboju wrote: > On 12 March 2018 at 22:21, Daniel Vacek wrote: >> On Mon, Mar 12, 2018 at 3:49 PM, Naresh Kamboju >> wrote: >>> On 12 March 2018 at 17:56, Sudeep Holla wrote: Hi, I couldn't find the exact mail corresponding to the patch me

Re: [PATCH v3 2/2] mm/page_alloc: fix memmap_init_zone pageblock alignment

2018-03-12 Thread Naresh Kamboju
On 12 March 2018 at 22:21, Daniel Vacek wrote: > On Mon, Mar 12, 2018 at 3:49 PM, Naresh Kamboju > wrote: >> On 12 March 2018 at 17:56, Sudeep Holla wrote: >>> Hi, >>> >>> I couldn't find the exact mail corresponding to the patch merged in >>> v4.16-rc5 >>> but commit 864b75f9d6b01 "mm/page_all

Re: [PATCH v3 2/2] mm/page_alloc: fix memmap_init_zone pageblock alignment

2018-03-12 Thread Sudeep Holla
On 12/03/18 16:51, Daniel Vacek wrote: [...] > > Hmm, does it step back perhaps? > > Can you check if below cures the boot hang? > Yes it does fix the boot hang. > --nX > > > neelx@metal:~/nX/src/linux$ git diff > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3d974cb2a1a1..41

Re: [PATCH v3 2/2] mm/page_alloc: fix memmap_init_zone pageblock alignment

2018-03-12 Thread Daniel Vacek
On Mon, Mar 12, 2018 at 3:49 PM, Naresh Kamboju wrote: > On 12 March 2018 at 17:56, Sudeep Holla wrote: >> Hi, >> >> I couldn't find the exact mail corresponding to the patch merged in v4.16-rc5 >> but commit 864b75f9d6b01 "mm/page_alloc: fix memmap_init_zone >> pageblock alignment" >> cause boot

Re: [PATCH v3 2/2] mm/page_alloc: fix memmap_init_zone pageblock alignment

2018-03-12 Thread Naresh Kamboju
On 12 March 2018 at 17:56, Sudeep Holla wrote: > Hi, > > I couldn't find the exact mail corresponding to the patch merged in v4.16-rc5 > but commit 864b75f9d6b01 "mm/page_alloc: fix memmap_init_zone > pageblock alignment" > cause boot hang on my ARM64 platform. I have also noticed this problem on

Re: [PATCH v3 2/2] mm/page_alloc: fix memmap_init_zone pageblock alignment

2018-03-12 Thread Sudeep Holla
Hi, I couldn't find the exact mail corresponding to the patch merged in v4.16-rc5 but commit 864b75f9d6b01 "mm/page_alloc: fix memmap_init_zone pageblock alignment" cause boot hang on my ARM64 platform. Log: [0.00] NUMA: No NUMA configuration found [0.00] NUMA: Faking a node at [m

Re: [PATCH v3 2/2] mm/page_alloc: fix memmap_init_zone pageblock alignment

2018-03-02 Thread Daniel Vacek
On Sat, Mar 3, 2018 at 1:40 AM, Andrew Morton wrote: > On Sat, 3 Mar 2018 01:12:26 +0100 Daniel Vacek wrote: > >> Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns >> where possible") introduced a bug where move_freepages() triggers a >> VM_BUG_ON() on uninitialized page st

Re: [PATCH v3 2/2] mm/page_alloc: fix memmap_init_zone pageblock alignment

2018-03-02 Thread Andrew Morton
On Sat, 3 Mar 2018 01:12:26 +0100 Daniel Vacek wrote: > Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns > where possible") introduced a bug where move_freepages() triggers a > VM_BUG_ON() on uninitialized page structure due to pageblock alignment. b92df1de5d28 was merged

[PATCH v3 2/2] mm/page_alloc: fix memmap_init_zone pageblock alignment

2018-03-02 Thread Daniel Vacek
Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns where possible") introduced a bug where move_freepages() triggers a VM_BUG_ON() on uninitialized page structure due to pageblock alignment. To fix this, simply align the skipped pfns in memmap_init_zone() the same way as in mov