Re: [PATCH v3 2/2] mmc: dw_mmc: add resets support to dw_mmc

2016-05-25 Thread Guodong Xu
On 2 April 2016 at 22:03, Heiko Stuebner wrote: > Am Samstag, 2. April 2016, 21:39:11 schrieb Guodong Xu: >> On 2 April 2016 at 02:42, Heiko Stuebner wrote: >> > Am Mittwoch, 30. März 2016, 15:24:56 schrieb Guodong Xu: >> > >> > [...] >> > >> > > @@ -2949,7 +2956,9 @@ int dw_mci_probe(struct dw_m

Re: [PATCH v3 2/2] mmc: dw_mmc: add resets support to dw_mmc

2016-04-03 Thread Jaehoon Chung
On 04/02/2016 03:42 AM, Heiko Stuebner wrote: > Am Mittwoch, 30. März 2016, 20:40:31 schrieb Jaehoon Chung: >> modified Rob's mail address. >> >> On 03/30/2016 04:24 PM, Guodong Xu wrote: >>> mmc registers may in abnormal state if mmc is used in bootloader, >>> eg. to support booting from eMMC. So

Re: [PATCH v3 2/2] mmc: dw_mmc: add resets support to dw_mmc

2016-04-02 Thread Heiko Stuebner
Am Samstag, 2. April 2016, 21:39:11 schrieb Guodong Xu: > On 2 April 2016 at 02:42, Heiko Stuebner wrote: > > Am Mittwoch, 30. März 2016, 15:24:56 schrieb Guodong Xu: > > > > [...] > > > > > @@ -2949,7 +2956,9 @@ int dw_mci_probe(struct dw_mci *host) > > > > > > if (!host->pdata) { > > >

Re: [PATCH v3 2/2] mmc: dw_mmc: add resets support to dw_mmc

2016-04-01 Thread Heiko Stuebner
Am Mittwoch, 30. März 2016, 15:24:56 schrieb Guodong Xu: [...] > @@ -2949,7 +2956,9 @@ int dw_mci_probe(struct dw_mci *host) > > if (!host->pdata) { > host->pdata = dw_mci_parse_dt(host); > - if (IS_ERR(host->pdata)) { > + if (PTR_ERR(host->pdata) == -

Re: [PATCH v3 2/2] mmc: dw_mmc: add resets support to dw_mmc

2016-04-01 Thread Heiko Stuebner
Am Mittwoch, 30. März 2016, 20:40:31 schrieb Jaehoon Chung: > modified Rob's mail address. > > On 03/30/2016 04:24 PM, Guodong Xu wrote: > > mmc registers may in abnormal state if mmc is used in bootloader, > > eg. to support booting from eMMC. So we need reset mmc registers > > when kernel boots

Re: [PATCH v3 2/2] mmc: dw_mmc: add resets support to dw_mmc

2016-03-30 Thread Jaehoon Chung
modified Rob's mail address. On 03/30/2016 04:24 PM, Guodong Xu wrote: > mmc registers may in abnormal state if mmc is used in bootloader, > eg. to support booting from eMMC. So we need reset mmc registers > when kernel boots up, instead of assuming mmc is in clean state. Do you mean mmc(card sid

[PATCH v3 2/2] mmc: dw_mmc: add resets support to dw_mmc

2016-03-30 Thread Guodong Xu
mmc registers may in abnormal state if mmc is used in bootloader, eg. to support booting from eMMC. So we need reset mmc registers when kernel boots up, instead of assuming mmc is in clean state. With this patch, user can add a 'resets' property into dw_mmc dts node. When driver parse_dt and probe