Re: [PATCH v3 2/2] nvdimm: Remove dead code for ENODEV checking in scan_labels()

2024-08-21 Thread Ira Weiny
Li Zhijian wrote: > The only way create_namespace_pmem() returns an ENODEV code is if > select_pmem_id(nd_region, &uuid) returns ENODEV when its 2nd parameter > is a null pointer. However, this is impossible because &uuid is always > valid. > > Furthermore, create_namespace_pmem() is the only user

[PATCH v3 2/2] nvdimm: Remove dead code for ENODEV checking in scan_labels()

2024-08-18 Thread Li Zhijian
The only way create_namespace_pmem() returns an ENODEV code is if select_pmem_id(nd_region, &uuid) returns ENODEV when its 2nd parameter is a null pointer. However, this is impossible because &uuid is always valid. Furthermore, create_namespace_pmem() is the only user of select_pmem_id(), it's saf