Hello Henry,
On Thu, Jul 23, 2015 at 1:04 PM, Henry Chen wrote:
> On Thu, 2015-07-23 at 11:07 +0200, Javier Martinez Canillas wrote:
>
>> > +
>> > + if (ret < 0)
>> > + dev_err(&i2c->dev, "Failed to initialize regulator: %d\n",
>> > ret);
>> > +
>>
>> I don't think this is ne
Hi Henry,
On Thu, Jul 23, 2015 at 7:04 PM, Henry Chen wrote:
>
> On Thu, 2015-07-23 at 11:07 +0200, Javier Martinez Canillas wrote:
>
> > > +
> > > + if (ret < 0)
> > > + dev_err(&i2c->dev, "Failed to initialize regulator:
> > > %d\n", ret);
> > > +
> >
> > I don't think this
On Thu, 2015-07-23 at 11:07 +0200, Javier Martinez Canillas wrote:
> > +
> > + if (ret < 0)
> > + dev_err(&i2c->dev, "Failed to initialize regulator: %d\n",
> > ret);
> > +
>
> I don't think this is necessary, you are already adding logs for all
> the error conditions.
Yes,
Hello Henry,
Driver looks mostly good for me now but I just found some things I
missed in the last revision.
On Thu, Jul 23, 2015 at 5:39 AM, Henry Chen wrote:
> Add regulator support for mt6311.
> It has 2 regulaotrs - Buck and LDO, provide the related buck/ldo voltage
> data to the driver, and
Add regulator support for mt6311.
It has 2 regulaotrs - Buck and LDO, provide the related buck/ldo voltage
data to the driver, and creates the regulator_desc table. Supported
operations for Buck are enabled/disabled and voltage change, only
enabled/disabled for LDO.
Signed-off-by: Henry Chen
---
5 matches
Mail list logo
