Re: [PATCH v3 2/2] regulator: mt6360: Add DT binding documentation

2020-08-25 Thread Gene Chen
Mark Brown 於 2020年8月25日 週二 下午6:08寫道： > > On Tue, Aug 25, 2020 at 06:01:46PM +0800, Gene Chen wrote: > > Mark Brown 於 2020年8月25日 週二 下午5:34寫道： > > > > > LDO_VINx is HW design layout, so actually it can't be changed by device > > > > tree. > > > > LDO_VIN1/LDO_VIN2 supply from VSYS, not regulator,

Re: [PATCH v3 2/2] regulator: mt6360: Add DT binding documentation

2020-08-25 Thread Mark Brown
On Tue, Aug 25, 2020 at 06:01:46PM +0800, Gene Chen wrote: > Mark Brown 於 2020年8月25日 週二 下午5:34寫道： > > > LDO_VINx is HW design layout, so actually it can't be changed by device > > > tree. > > > LDO_VIN1/LDO_VIN2 supply from VSYS, not regulator, so I think usually > > > not to show the supply fro

Re: [PATCH v3 2/2] regulator: mt6360: Add DT binding documentation

2020-08-25 Thread Gene Chen
Mark Brown 於 2020年8月25日 週二 下午5:34寫道： > > On Tue, Aug 25, 2020 at 05:21:06PM +0800, Gene Chen wrote: > > Mark Brown 於 2020年8月25日 週二 上午3:49寫道： > > > > So shouldn't there be a documented LDO_VIN1/2 then? > > > LDO_VINx is HW design layout, so actually it can't be changed by device > > tree. > > LDO

Re: [PATCH v3 2/2] regulator: mt6360: Add DT binding documentation

2020-08-25 Thread Mark Brown
On Tue, Aug 25, 2020 at 05:21:06PM +0800, Gene Chen wrote: > Mark Brown 於 2020年8月25日 週二 上午3:49寫道： > > So shouldn't there be a documented LDO_VIN1/2 then? > LDO_VINx is HW design layout, so actually it can't be changed by device tree. > LDO_VIN1/LDO_VIN2 supply from VSYS, not regulator, so I thin

Re: [PATCH v3 2/2] regulator: mt6360: Add DT binding documentation

2020-08-25 Thread Gene Chen
Mark Brown 於 2020年8月25日 週二 上午3:49寫道： > > On Mon, Aug 24, 2020 at 03:21:57PM +0800, Gene Chen wrote: > > > On Thu, Aug 20, 2020 at 03:53:42PM +0800, Gene Chen wrote: > > > > > + LDO_VIN3-supply: > > > > +description: Input supply phandle(s) for LDO3 > > > > Only LDO3 needs a supply? > > > LDO_

Re: [PATCH v3 2/2] regulator: mt6360: Add DT binding documentation

2020-08-24 Thread Mark Brown
On Mon, Aug 24, 2020 at 03:21:57PM +0800, Gene Chen wrote: > > On Thu, Aug 20, 2020 at 03:53:42PM +0800, Gene Chen wrote: > > > + LDO_VIN3-supply: > > > +description: Input supply phandle(s) for LDO3 > > Only LDO3 needs a supply? > LDO_VIN1/LDO_VIN2 is real MT6360 pin supply from VSYS to LD

Re: [PATCH v3 2/2] regulator: mt6360: Add DT binding documentation

2020-08-24 Thread Gene Chen
⊕ Mark Brown 於 2020年8月20日 週四 下午7:30寫道： > > On Thu, Aug 20, 2020 at 03:53:42PM +0800, Gene Chen wrote: > > > +properties: > > + compatible: > > +const: mediatek,mt6360-regulator > > + > > + LDO_VIN3-supply: > > +description: Input supply phandle(s) for LDO3 > > + > > Only LDO3 needs a su

Re: [PATCH v3 2/2] regulator: mt6360: Add DT binding documentation

2020-08-20 Thread Mark Brown
On Thu, Aug 20, 2020 at 03:53:42PM +0800, Gene Chen wrote: > +properties: > + compatible: > +const: mediatek,mt6360-regulator > + > + LDO_VIN3-supply: > +description: Input supply phandle(s) for LDO3 > + Only LDO3 needs a supply? signature.asc Description: PGP signature

[PATCH v3 2/2] regulator: mt6360: Add DT binding documentation

2020-08-20 Thread Gene Chen
From: Gene Chen Add a devicetree binding documentation for the mt6360 regulator driver. Signed-off-by: Gene Chen --- .../bindings/regulator/mt6360-regulator.yaml | 109 + 1 file changed, 109 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulato