Re: [PATCH v3 2/2] soundwire: qcom: add support for SoundWire controller

2019-10-20 Thread Vinod Koul
On 11-10-19, 16:44, Srinivas Kandagatla wrote: > +static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) > +{ > + struct qcom_swrm_ctrl *ctrl = dev_id; > + u32 sts, value; > + unsigned long flags; > + > + ctrl->reg_read(ctrl, SWRM_INTERRUPT_STATUS, &sts); > + > + if (s

Re: [alsa-devel] [PATCH v3 2/2] soundwire: qcom: add support for SoundWire controller

2019-10-14 Thread Pierre-Louis Bossart
On 10/14/19 4:04 AM, Srinivas Kandagatla wrote: Thanks Pierre for taking time to review the patch. On 11/10/2019 18:50, Pierre-Louis Bossart wrote: +static int qcom_swrm_cmd_fifo_wr_cmd(struct qcom_swrm_ctrl *ctrl, u8 cmd_data, + u8 dev_addr, u16 reg_addr) +{ +    DECL

Re: [PATCH v3 2/2] soundwire: qcom: add support for SoundWire controller

2019-10-14 Thread Srinivas Kandagatla
Thanks Pierre for taking time to review the patch. On 11/10/2019 18:50, Pierre-Louis Bossart wrote: +static int qcom_swrm_cmd_fifo_wr_cmd(struct qcom_swrm_ctrl *ctrl, u8 cmd_data, + u8 dev_addr, u16 reg_addr) +{ +    DECLARE_COMPLETION_ONSTACK(comp); +    unsigned long fla

Re: [PATCH v3 2/2] soundwire: qcom: add support for SoundWire controller

2019-10-11 Thread Pierre-Louis Bossart
+static int qcom_swrm_cmd_fifo_wr_cmd(struct qcom_swrm_ctrl *ctrl, u8 cmd_data, +u8 dev_addr, u16 reg_addr) +{ + DECLARE_COMPLETION_ONSTACK(comp); + unsigned long flags; + u32 val; + int ret; + + spin_lock_irqsave(&ctrl->comp_loc

[PATCH v3 2/2] soundwire: qcom: add support for SoundWire controller

2019-10-11 Thread Srinivas Kandagatla
Qualcomm SoundWire Master controller is present in most Qualcomm SoCs either integrated as part of WCD audio codecs via slimbus or as part of SOC I/O. This patchset adds support to a very basic controller which has been tested with WCD934x SoundWire controller connected to WSA881x smart speaker am