Re: [PATCH v3 2/2] tty: serial: add driver for the SiFive UART

2018-11-15 Thread Paul Walmsley
Hi Emil, On Thu, 15 Nov 2018, Emil Renner Berthing wrote: Thanks for the patch! Thanks for your comments! On Sat, 20 Oct 2018 at 12:12, Paul Walmsley wrote: +static int __init sifive_serial_console_setup(struct console *co, char *options) Unfortunately I get this error unless I remove

Re: [PATCH v3 2/2] tty: serial: add driver for the SiFive UART

2018-11-15 Thread Emil Renner Berthing
Hi Paul, Thanks for the patch! On Sat, 20 Oct 2018 at 12:12, Paul Walmsley wrote: > +/* > + * > + */ Interesting comment ;) > +static int __init sifive_serial_console_setup(struct console *co, char > *options) Unfortunately I get this error unless I remove the __init: ... GEN .version

[PATCH v3 2/2] tty: serial: add driver for the SiFive UART

2018-10-20 Thread Paul Walmsley
Add a serial driver for the SiFive UART, found on SiFive FU540 devices (among others). The underlying serial IP block is relatively basic, and currently does not support serial break detection. Further information on the IP block can be found in the documentation and Chisel sources: https://stat