RE: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-17 Thread Paul Zimmerman
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > Sent: Thursday, October 16, 2014 9:44 PM > > modified the function to have a single return statement at the end > instead of multiple return statement in the middle of the function > to improve the readability of the code. > > This pat

RE: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-17 Thread Paul Zimmerman
> From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > Sent: Friday, October 17, 2014 3:03 AM > > On Fri, Oct 17, 2014 at 09:02:00AM +, David Laight wrote: > > From: Of Sudip Mukherjee > > > modified the function to have a single return statement at the end > > > instead of multiple ret

Re: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-17 Thread Sudip Mukherjee
On Fri, Oct 17, 2014 at 09:02:00AM +, David Laight wrote: > From: Of Sudip Mukherjee > > modified the function to have a single return statement at the end > > instead of multiple return statement in the middle of the function > > to improve the readability of the code. > > Many of us would di

RE: [PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-17 Thread David Laight
From: Of Sudip Mukherjee > modified the function to have a single return statement at the end > instead of multiple return statement in the middle of the function > to improve the readability of the code. Many of us would disagree with you there. Early returns actually make the code easier to read

[PATCH v3 2/2] usb: dwc2: gadget: modify return statement

2014-10-16 Thread Sudip Mukherjee
modified the function to have a single return statement at the end instead of multiple return statement in the middle of the function to improve the readability of the code. This patch depends on the previous patch of the series. Signed-off-by: Sudip Mukherjee --- drivers/usb/dwc2/gadget.c | 4