Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-05 Thread Hans de Goede
Hi, On 05-05-16 18:00, Stephen Warren wrote: On 05/05/2016 02:05 AM, Hans de Goede wrote: Hi, On 04-05-16 22:25, Thierry Reding wrote: On Wed, May 04, 2016 at 11:23:20AM -0600, Stephen Warren wrote: On 05/04/2016 08:40 AM, Thierry Reding wrote: From: Thierry Reding Starting with commit 0b

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-05 Thread Jon Hunter
On 05/05/16 18:05, Jon Hunter wrote: [snip] > I spent a bit of time looking at this to figure out what it is doing. Can we > simply > this a bit as follows (limited testing so far) ... > > Cheers > Jon > > diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c > index c1c

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-05 Thread Jon Hunter
On 04/05/16 15:40, Thierry Reding wrote: > From: Thierry Reding > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > controls") there is a reference count for reset control assertions. The > goal is to allow resets to be shared by multiple devices and an assert > will ta

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-05 Thread Stephen Warren
On 05/05/2016 02:05 AM, Hans de Goede wrote: Hi, On 04-05-16 22:25, Thierry Reding wrote: On Wed, May 04, 2016 at 11:23:20AM -0600, Stephen Warren wrote: On 05/04/2016 08:40 AM, Thierry Reding wrote: From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared rese

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-05 Thread Hans de Goede
Hi, On 04-05-16 22:25, Thierry Reding wrote: On Wed, May 04, 2016 at 11:23:20AM -0600, Stephen Warren wrote: On 05/04/2016 08:40 AM, Thierry Reding wrote: From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared reset controls") there is a reference count for re

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Thierry Reding
On Wed, May 04, 2016 at 11:23:20AM -0600, Stephen Warren wrote: > On 05/04/2016 08:40 AM, Thierry Reding wrote: > > From: Thierry Reding > > > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > > controls") there is a reference count for reset control assertions. The > >

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Thierry Reding
On Wed, May 04, 2016 at 07:22:54PM +0200, Philipp Zabel wrote: > Hi Thierry, > > Am Mittwoch, den 04.05.2016, 16:40 +0200 schrieb Thierry Reding: > > From: Thierry Reding > > > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > > controls") there is a reference count for

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Stephen Warren
On 05/04/2016 08:40 AM, Thierry Reding wrote: From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared reset controls") there is a reference count for reset control assertions. The goal is to allow resets to be shared by multiple devices and an assert will take eff

Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Philipp Zabel
Hi Thierry, Am Mittwoch, den 04.05.2016, 16:40 +0200 schrieb Thierry Reding: > From: Thierry Reding > > Starting with commit 0b52297f2288 ("reset: Add support for shared reset > controls") there is a reference count for reset control assertions. The > goal is to allow resets to be shared by mult

[PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice

2016-05-04 Thread Thierry Reding
From: Thierry Reding Starting with commit 0b52297f2288 ("reset: Add support for shared reset controls") there is a reference count for reset control assertions. The goal is to allow resets to be shared by multiple devices and an assert will take effect only when all instances have asserted the re