Re: [PATCH v3 2/3] HID: i2c-hid: Allow subclasses of i2c-hid for power sequencing

2020-11-03 Thread Dmitry Torokhov
On Tue, Nov 03, 2020 at 01:42:47PM +0100, Benjamin Tissoires wrote: > > I also want to say that I like the general idea of Doug's patch. > Having a separate driver that handles the specific use case of goodix > is really nice, as it allows to just load this driver without touching > the core of i2

Re: [PATCH v3 2/3] HID: i2c-hid: Allow subclasses of i2c-hid for power sequencing

2020-11-03 Thread Benjamin Tissoires
Hi, On Tue, Nov 3, 2020 at 10:09 AM Hans de Goede wrote: > > Hi, > > On 11/3/20 2:46 AM, Rob Herring wrote: > > On Mon, Nov 2, 2020 at 6:13 PM Douglas Anderson > > wrote: > >> > >> This exports some things from i2c-hid so that we can have a driver > >> that's effectively a subclass of it and th

Re: [PATCH v3 2/3] HID: i2c-hid: Allow subclasses of i2c-hid for power sequencing

2020-11-03 Thread Hans de Goede
Hi, On 11/3/20 2:46 AM, Rob Herring wrote: > On Mon, Nov 2, 2020 at 6:13 PM Douglas Anderson wrote: >> >> This exports some things from i2c-hid so that we can have a driver >> that's effectively a subclass of it and that can do its own power >> sequencing. >> >> Signed-off-by: Douglas Anderson >

Re: [PATCH v3 2/3] HID: i2c-hid: Allow subclasses of i2c-hid for power sequencing

2020-11-02 Thread Rob Herring
On Mon, Nov 2, 2020 at 6:13 PM Douglas Anderson wrote: > > This exports some things from i2c-hid so that we can have a driver > that's effectively a subclass of it and that can do its own power > sequencing. > > Signed-off-by: Douglas Anderson > --- > > Changes in v3: > - Rework to use subclassin

[PATCH v3 2/3] HID: i2c-hid: Allow subclasses of i2c-hid for power sequencing

2020-11-02 Thread Douglas Anderson
This exports some things from i2c-hid so that we can have a driver that's effectively a subclass of it and that can do its own power sequencing. Signed-off-by: Douglas Anderson --- Changes in v3: - Rework to use subclassing. Changes in v2: - Use a separate compatible string for this new touchsc