Re: [PATCH v3 2/3] Input: gpio_keys - convert to use devm_*

2014-04-28 Thread Andy Shevchenko
On Fri, 2014-04-25 at 21:43 -0700, Dmitry Torokhov wrote: > On Fri, Apr 25, 2014 at 07:22:16PM +0300, Andy Shevchenko wrote: > > This makes the error handling much more simpler than open-coding everything > > and > > in addition makes the probe function smaller an tidier. [] > > - pdata =

Re: [PATCH v3 2/3] Input: gpio_keys - convert to use devm_*

2014-04-28 Thread Andy Shevchenko
On Fri, 2014-04-25 at 21:43 -0700, Dmitry Torokhov wrote: On Fri, Apr 25, 2014 at 07:22:16PM +0300, Andy Shevchenko wrote: This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller an tidier. [] - pdata =

Re: [PATCH v3 2/3] Input: gpio_keys - convert to use devm_*

2014-04-25 Thread Dmitry Torokhov
On Fri, Apr 25, 2014 at 07:22:16PM +0300, Andy Shevchenko wrote: > This makes the error handling much more simpler than open-coding everything > and > in addition makes the probe function smaller an tidier. > > Signed-off-by: Andy Shevchenko > Acked-by: Linus Walleij > --- >

[PATCH v3 2/3] Input: gpio_keys - convert to use devm_*

2014-04-25 Thread Andy Shevchenko
This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller an tidier. Signed-off-by: Andy Shevchenko Acked-by: Linus Walleij --- drivers/input/keyboard/gpio_keys.c | 75 +- 1 file changed, 25

[PATCH v3 2/3] Input: gpio_keys - convert to use devm_*

2014-04-25 Thread Andy Shevchenko
This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller an tidier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Linus Walleij linus.wall...@linaro.org --- drivers/input/keyboard/gpio_keys.c | 75

Re: [PATCH v3 2/3] Input: gpio_keys - convert to use devm_*

2014-04-25 Thread Dmitry Torokhov
On Fri, Apr 25, 2014 at 07:22:16PM +0300, Andy Shevchenko wrote: This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller an tidier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Linus Walleij