Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-09 Thread Arnd Bergmann
On Thursday 09 January 2014, Roger Quadros wrote: > >> if (!IS_ERR(hpriv->phy)) { > >> rc = phy_init(hpriv->phy); > >> if (rc) > >> goto disable_unprepare_clk; > >> > >> rc = phy_power_on(hpriv->phy); > >> if (rc) { > >> phy_exit(hpriv

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Roger Quadros
On 01/08/2014 05:16 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 16:58:15 Roger Quadros wrote: >> hpriv->phy = devm_phy_get(dev, "sata-phy"); >> if (IS_ERR(hpriv->phy)) { >> if (PTR_ERR(hpriv->phy) == -ENODEV) >> goto continue; >> >> dev_err(dev, "couldn't

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Hans de Goede
Hi, On 01/08/2014 02:14 PM, Hans de Goede wrote: Hi, On 01/08/2014 12:28 PM, Roger Quadros wrote: On 01/08/2014 03:35 PM, Arnd Bergmann wrote: On Wednesday 08 January 2014 15:29:18 Kishon Vijay Abraham I wrote: + hpriv->phy = devm_phy_get(dev, "sata-phy"); + if (IS_ERR(hpriv->phy)) {

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Hans de Goede
Hi, On 01/08/2014 12:28 PM, Roger Quadros wrote: On 01/08/2014 03:35 PM, Arnd Bergmann wrote: On Wednesday 08 January 2014 15:29:18 Kishon Vijay Abraham I wrote: + hpriv->phy = devm_phy_get(dev, "sata-phy"); + if (IS_ERR(hpriv->phy)) { + dev_dbg(dev, "can't get sata-phy\n")

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 16:58:15 Roger Quadros wrote: > hpriv->phy = devm_phy_get(dev, "sata-phy"); > if (IS_ERR(hpriv->phy)) { > if (PTR_ERR(hpriv->phy) == -ENODEV) > goto continue; > > dev_err(dev, "couldn't get sata-phy\n"); > rc = PTR_ERR(hpriv->phy

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Roger Quadros
On 01/08/2014 04:58 PM, Roger Quadros wrote: > On 01/08/2014 03:35 PM, Arnd Bergmann wrote: >> On Wednesday 08 January 2014 15:29:18 Kishon Vijay Abraham I wrote: + hpriv->phy = devm_phy_get(dev, "sata-phy"); + if (IS_ERR(hpriv->phy)) { + dev_dbg(dev, "can't get s

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Roger Quadros
On 01/08/2014 03:35 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 15:29:18 Kishon Vijay Abraham I wrote: >>> + hpriv->phy = devm_phy_get(dev, "sata-phy"); >>> + if (IS_ERR(hpriv->phy)) { >>> + dev_dbg(dev, "can't get sata-phy\n"); >>> + /* return only if -E

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 15:29:18 Kishon Vijay Abraham I wrote: > > + hpriv->phy = devm_phy_get(dev, "sata-phy"); > > + if (IS_ERR(hpriv->phy)) { > > + dev_dbg(dev, "can't get sata-phy\n"); > > + /* return only if -EPROBE_DEFER */ > > + if (PTR_ERR(hp

Re: [PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Kishon Vijay Abraham I
Hi Roger, On Wednesday 08 January 2014 03:17 PM, Roger Quadros wrote: > From: Balaji T K > > Some platforms have a PHY hooked up to the > SATA controller. The PHY needs to be initialized > and powered up for SATA to work. We do that > using the PHY framework. > > [Roger Q] Cleaned up. > > CC:

[PATCH v3 2/3] ata: ahci_platform: Manage SATA PHY

2014-01-08 Thread Roger Quadros
From: Balaji T K Some platforms have a PHY hooked up to the SATA controller. The PHY needs to be initialized and powered up for SATA to work. We do that using the PHY framework. [Roger Q] Cleaned up. CC: Tejun Heo Signed-off-by: Balaji T K Signed-off-by: Roger Quadros --- drivers/ata/ahci.h