Re: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules

2015-05-24 Thread Pali Rohár
On Sunday 24 May 2015 07:07:36 valdis.kletni...@vt.edu wrote: > On Sat, 23 May 2015 03:05:50 +0200, Pali Rohár said: > > I'm thinking about using symbol_request() in dell-laptop.c (instead > > hard=20 dependency) and then not ignoring error here... It could > > fix this=20 problem. > > That would

Re: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules

2015-05-23 Thread Valdis . Kletnieks
On Sat, 23 May 2015 03:05:50 +0200, Pali Rohár said: > I'm thinking about using symbol_request() in dell-laptop.c (instead hard=20 > dependency) and then not ignoring error here... It could fix this=20 > problem. That would also address the problem of a build that has DELL_LAPTOP=[ym] but DELL_RB

Re: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules

2015-05-22 Thread Pali Rohár
On Saturday 23 May 2015 00:45:57 Dmitry Torokhov wrote: > On Thu, May 14, 2015 at 3:54 AM, Pali Rohár > wrote: > > @@ -328,7 +408,9 @@ static void rbtn_notify(struct acpi_device > > *device, u32 event) > > > > static int __init rbtn_init(void) > > { > > > > - return acpi_bus_register_dri

Re: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules

2015-05-22 Thread Dmitry Torokhov
On Thu, May 14, 2015 at 3:54 AM, Pali Rohár wrote: > @@ -328,7 +408,9 @@ static void rbtn_notify(struct acpi_device *device, u32 > event) > > static int __init rbtn_init(void) > { > - return acpi_bus_register_driver(&rbtn_driver); > + /* ignore errors so module always loads and exp

[PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules

2015-05-14 Thread Pali Rohár
This patch exports notifier functions so other modules can receive HW switch events. By default when some module register notifier, dell-rbtn driver automatically remove rfkill interfaces from system (it is expected that other module will use events for other rfkill interface). This behaviour can b