Re: [PATCH v3 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-10-03 Thread Sakari Ailus
Hi Manivannan, On Thu, Oct 03, 2019 at 12:56:48PM +0530, Manivannan Sadhasivam wrote: > >> mentioned in the datasheet. I agree that we are missing the userspace > >> granularity here but sticking to the device limitation shouldn't be a > >problem. > >> As I said, I'll add a comment here to

Re: [PATCH v3 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-10-03 Thread Manivannan Sadhasivam
Hi Sakari, On 3 October 2019 12:46:46 PM IST, Sakari Ailus wrote: >Hi Manivannan, > >On Thu, Oct 03, 2019 at 11:03:38AM +0530, Manivannan Sadhasivam wrote: > >> > > > > +static int imx290_set_gain(struct imx290 *imx290, u32 value) >> > > > > +{ >> > > > > +int ret; >> > > > > + >> > > >

Re: [PATCH v3 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-10-03 Thread Sakari Ailus
Hi Manivannan, On Thu, Oct 03, 2019 at 11:03:38AM +0530, Manivannan Sadhasivam wrote: > > > > > +static int imx290_set_gain(struct imx290 *imx290, u32 value) > > > > > +{ > > > > > + int ret; > > > > > + > > > > > + u32 adjusted_value = (value * 10) / 3; > > > > > > > > What's the

Re: [PATCH v3 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-10-02 Thread Manivannan Sadhasivam
Hi Sakari, On Wed, Oct 02, 2019 at 01:37:15PM +0300, Sakari Ailus wrote: > Hi Manivannan, > > On Wed, Oct 02, 2019 at 12:12:00AM +0530, Manivannan Sadhasivam wrote: > > Hi Sakari, > > > > On Mon, Sep 23, 2019 at 12:22:09PM +0300, Sakari Ailus wrote: > > > Hi Manivannan, > > > > > > On Fri, Aug

Re: [PATCH v3 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-10-02 Thread Sakari Ailus
Hi Manivannan, On Wed, Oct 02, 2019 at 12:12:00AM +0530, Manivannan Sadhasivam wrote: > Hi Sakari, > > On Mon, Sep 23, 2019 at 12:22:09PM +0300, Sakari Ailus wrote: > > Hi Manivannan, > > > > On Fri, Aug 30, 2019 at 02:49:42PM +0530, Manivannan Sadhasivam wrote: > > > Add driver for Sony IMX290

Re: [PATCH v3 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-10-01 Thread Manivannan Sadhasivam
Hi Sakari, On Mon, Sep 23, 2019 at 12:22:09PM +0300, Sakari Ailus wrote: > Hi Manivannan, > > On Fri, Aug 30, 2019 at 02:49:42PM +0530, Manivannan Sadhasivam wrote: > > Add driver for Sony IMX290 CMOS image sensor driver. The driver only > > supports I2C interface for programming and MIPI CSI-2

Re: [PATCH v3 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-09-23 Thread Sakari Ailus
Hi Manivannan, On Fri, Aug 30, 2019 at 02:49:42PM +0530, Manivannan Sadhasivam wrote: > Add driver for Sony IMX290 CMOS image sensor driver. The driver only > supports I2C interface for programming and MIPI CSI-2 for sensor output. > > Signed-off-by: Manivannan Sadhasivam > --- >

[PATCH v3 2/3] media: i2c: Add IMX290 CMOS image sensor driver

2019-08-30 Thread Manivannan Sadhasivam
Add driver for Sony IMX290 CMOS image sensor driver. The driver only supports I2C interface for programming and MIPI CSI-2 for sensor output. Signed-off-by: Manivannan Sadhasivam --- drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/imx290.c | 881