Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, On 11/14/2017 03:28 PM, Felipe Balbi wrote: > Hi, > > Mathias Nyman writes: >>> +static int dbc_buf_alloc(struct dbc_buf *db, unsigned int size) >>> +{ >>> + db->buf_buf = kzalloc(size, GFP_KERNEL); >>> + if (!db->buf_buf) >>> + return -ENOMEM;

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, On 11/14/2017 03:28 PM, Felipe Balbi wrote: > Hi, > > Mathias Nyman writes: >>> +static int dbc_buf_alloc(struct dbc_buf *db, unsigned int size) >>> +{ >>> + db->buf_buf = kzalloc(size, GFP_KERNEL); >>> + if (!db->buf_buf) >>> + return -ENOMEM; >>> + >>> + db->buf_size =

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Mathias Nyman writes: >> +static int dbc_buf_alloc(struct dbc_buf *db, unsigned int size) >> +{ >> +db->buf_buf = kzalloc(size, GFP_KERNEL); >> +if (!db->buf_buf) >> +return -ENOMEM; >> + >> +db->buf_size = size; >> +db->buf_put =

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Mathias Nyman writes: >> +static int dbc_buf_alloc(struct dbc_buf *db, unsigned int size) >> +{ >> +db->buf_buf = kzalloc(size, GFP_KERNEL); >> +if (!db->buf_buf) >> +return -ENOMEM; >> + >> +db->buf_size = size; >> +db->buf_put = db->buf_buf; >> +db->buf_get

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Ok, review last part diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c new file mode 100644 index 000..fe5fef0 --- /dev/null +++ b/drivers/usb/host/xhci-dbgtty.c @@ -0,0 +1,586 @@ +/** + * xhci-dbgtty.c - tty glue for xHCI debug capability + * + * Copyright (C)

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Ok, review last part diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c new file mode 100644 index 000..fe5fef0 --- /dev/null +++ b/drivers/usb/host/xhci-dbgtty.c @@ -0,0 +1,586 @@ +/** + * xhci-dbgtty.c - tty glue for xHCI debug capability + * + * Copyright (C)

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, On 11/06/2017 04:00 PM, Greg Kroah-Hartman wrote: > On Mon, Nov 06, 2017 at 08:35:41AM +0800, Lu Baolu wrote: >> Hi, >> >> On 11/03/2017 02:27 PM, Greg Kroah-Hartman wrote: >>> On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: Hi, On 11/03/2017 12:51 AM, Greg

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, On 11/06/2017 04:00 PM, Greg Kroah-Hartman wrote: > On Mon, Nov 06, 2017 at 08:35:41AM +0800, Lu Baolu wrote: >> Hi, >> >> On 11/03/2017 02:27 PM, Greg Kroah-Hartman wrote: >>> On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: Hi, On 11/03/2017 12:51 AM, Greg

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Mon, Nov 06, 2017 at 08:35:41AM +0800, Lu Baolu wrote: > Hi, > > On 11/03/2017 02:27 PM, Greg Kroah-Hartman wrote: > > On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: > >> Hi, > >> > >> On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: > >>> On Thu, Nov 02, 2017 at 12:38:57PM +0200,

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Mon, Nov 06, 2017 at 08:35:41AM +0800, Lu Baolu wrote: > Hi, > > On 11/03/2017 02:27 PM, Greg Kroah-Hartman wrote: > > On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: > >> Hi, > >> > >> On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: > >>> On Thu, Nov 02, 2017 at 12:38:57PM +0200,

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, On 11/03/2017 02:27 PM, Greg Kroah-Hartman wrote: > On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: >> Hi, >> >> On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: >>> On Thu, Nov 02, 2017 at 12:38:57PM +0200, Felipe Balbi wrote: > Hi, > > Greg Kroah-Hartman

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, On 11/03/2017 02:27 PM, Greg Kroah-Hartman wrote: > On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: >> Hi, >> >> On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: >>> On Thu, Nov 02, 2017 at 12:38:57PM +0200, Felipe Balbi wrote: > Hi, > > Greg Kroah-Hartman writes:

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> > >> Greg Kroah-Hartman writes: >> >>> > >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 >> >>> > >> >> > controllers) >> >>> > >> >> > can be implemented with the

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> > >> Greg Kroah-Hartman writes: >> >>> > >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 >> >>> > >> >> > controllers) >> >>> > >> >> > can be implemented with the Debug Capability(DbC). It >> >>> > >> >> > presents a

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: > Hi, > > On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: > > On Thu, Nov 02, 2017 at 12:38:57PM +0200, Felipe Balbi wrote: > >> > > >> > Hi, > >> > > >> > Greg Kroah-Hartman writes: > > >> Greg

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: > Hi, > > On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: > > On Thu, Nov 02, 2017 at 12:38:57PM +0200, Felipe Balbi wrote: > >> > > >> > Hi, > >> > > >> > Greg Kroah-Hartman writes: > > >> Greg Kroah-Hartman writes: > >>> >

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: > On Thu, Nov 02, 2017 at 12:38:57PM +0200, Felipe Balbi wrote: >> > >> > Hi, >> > >> > Greg Kroah-Hartman writes: > >> Greg Kroah-Hartman writes: >>> > >> >> > xHCI

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: > On Thu, Nov 02, 2017 at 12:38:57PM +0200, Felipe Balbi wrote: >> > >> > Hi, >> > >> > Greg Kroah-Hartman writes: > >> Greg Kroah-Hartman writes: >>> > >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 >>> >

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Thu, Nov 02, 2017 at 12:38:57PM +0200, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman writes: > >> Greg Kroah-Hartman writes: > >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 > >> >> > controllers) > >> >> >

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Thu, Nov 02, 2017 at 12:38:57PM +0200, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman writes: > >> Greg Kroah-Hartman writes: > >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 > >> >> > controllers) > >> >> > can be implemented with the Debug Capability(DbC). It

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> Greg Kroah-Hartman writes: >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> >> > can be implemented with the Debug Capability(DbC). It presents a debug >> >> > device

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> Greg Kroah-Hartman writes: >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> >> > can be implemented with the Debug Capability(DbC). It presents a debug >> >> > device which is fully compliant with the USB framework and

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Thu, Nov 02, 2017 at 11:15:43AM +0200, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman writes: > >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) > >> > can be implemented with the Debug Capability(DbC). It presents a debug > >> >

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Thu, Nov 02, 2017 at 11:15:43AM +0200, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman writes: > >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) > >> > can be implemented with the Debug Capability(DbC). It presents a debug > >> > device which is fully

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> > can be implemented with the Debug Capability(DbC). It presents a debug >> > device which is fully compliant with the USB framework and provides the >> >

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi, Greg Kroah-Hartman writes: >> > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) >> > can be implemented with the Debug Capability(DbC). It presents a debug >> > device which is fully compliant with the USB framework and provides the >> > equivalent of a very high

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Thu, Nov 02, 2017 at 09:36:42AM +0800, Lu Baolu wrote: > Hi Greg, > > On 09/05/2017 09:58 AM, Lu Baolu wrote: > > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) > > can be implemented with the Debug Capability(DbC). It presents a debug > > device which is fully

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

On Thu, Nov 02, 2017 at 09:36:42AM +0800, Lu Baolu wrote: > Hi Greg, > > On 09/05/2017 09:58 AM, Lu Baolu wrote: > > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) > > can be implemented with the Debug Capability(DbC). It presents a debug > > device which is fully

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi Greg, On 09/05/2017 09:58 AM, Lu Baolu wrote: > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) > can be implemented with the Debug Capability(DbC). It presents a debug > device which is fully compliant with the USB framework and provides the > equivalent of a very high

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi Greg, On 09/05/2017 09:58 AM, Lu Baolu wrote: > xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) > can be implemented with the Debug Capability(DbC). It presents a debug > device which is fully compliant with the USB framework and provides the > equivalent of a very high

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi Mathias, Thanks for your time. On 10/25/2017 01:03 AM, Mathias Nyman wrote: > Hi > > Skipping lists, partial review. > Many of the questions are real questions that I was wondering about > while lookinga the code. Not necessarily thing that must be changed. No problem. > > On 05.09.2017

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi Mathias, Thanks for your time. On 10/25/2017 01:03 AM, Mathias Nyman wrote: > Hi > > Skipping lists, partial review. > Many of the questions are real questions that I was wondering about > while lookinga the code. Not necessarily thing that must be changed. No problem. > > On 05.09.2017

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi Skipping lists, partial review. Many of the questions are real questions that I was wondering about while lookinga the code. Not necessarily thing that must be changed. On 05.09.2017 04:58, Lu Baolu wrote: xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) can be

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

Hi Skipping lists, partial review. Many of the questions are real questions that I was wondering about while lookinga the code. Not necessarily thing that must be changed. On 05.09.2017 04:58, Lu Baolu wrote: xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) can be

[PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) can be implemented with the Debug Capability(DbC). It presents a debug device which is fully compliant with the USB framework and provides the equivalent of a very high performance full-duplex serial link. The debug capability

[PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

xHCI compatible USB host controllers(i.e. super-speed USB3 controllers) can be implemented with the Debug Capability(DbC). It presents a debug device which is fully compliant with the USB framework and provides the equivalent of a very high performance full-duplex serial link. The debug capability