Re: [PATCH v3 2/4] Add the latent_entropy gcc plugin

2016-06-15 Thread Kees Cook
On Wed, Jun 15, 2016 at 1:49 PM, Emese Revfy wrote: > On Wed, 15 Jun 2016 11:07:08 -0700 > Kees Cook wrote: > >> On Tue, Jun 14, 2016 at 3:20 PM, Emese Revfy wrote: > >> This doesn't look right to me: these are CFLAGS_REMOVE_* entries, and >> I think you want to _add_ the DISABLE_LATENT_ENTROPY_

Re: [PATCH v3 2/4] Add the latent_entropy gcc plugin

2016-06-15 Thread Emese Revfy
On Wed, 15 Jun 2016 11:07:08 -0700 Kees Cook wrote: > On Tue, Jun 14, 2016 at 3:20 PM, Emese Revfy wrote: > This doesn't look right to me: these are CFLAGS_REMOVE_* entries, and > I think you want to _add_ the DISABLE_LATENT_ENTROPY_PLUGIN to the > CFLAGS here. Thanks for the report. I think

Re: [PATCH v3 2/4] Add the latent_entropy gcc plugin

2016-06-15 Thread Kees Cook
On Tue, Jun 14, 2016 at 3:20 PM, Emese Revfy wrote: > This plugin mitigates the problem of the kernel having too little entropy > during > and after boot for generating crypto keys. > > It creates a local variable in every marked function. The value of this > variable is > modified by randomly c

[PATCH v3 2/4] Add the latent_entropy gcc plugin

2016-06-14 Thread Emese Revfy
This plugin mitigates the problem of the kernel having too little entropy during and after boot for generating crypto keys. It creates a local variable in every marked function. The value of this variable is modified by randomly chosen operations (add, xor and rol) and random values (gcc generate