Re: [PATCH v3 2/4] clk: mediatek: Add initial common clock support for Mediatek SoCs.

2015-01-20 Thread Matthias Brugger
2015-01-08 3:55 GMT+01:00 James Liao : > Hi Matthias, > > On Wed, 2015-01-07 at 18:22 +0100, Matthias Brugger wrote: >> 2015-01-07 4:25 GMT+01:00 James Liao : [...] >> > + >> > +extern spinlock_t *get_mtk_clk_lock(void); >> > + >> > +#define mtk_clk_lock(flags)

Re: [PATCH v3 2/4] clk: mediatek: Add initial common clock support for Mediatek SoCs.

2015-01-20 Thread Matthias Brugger
2015-01-08 3:55 GMT+01:00 James Liao jamesjj.l...@mediatek.com: Hi Matthias, On Wed, 2015-01-07 at 18:22 +0100, Matthias Brugger wrote: 2015-01-07 4:25 GMT+01:00 James Liao jamesjj.l...@mediatek.com: [...] + +extern spinlock_t *get_mtk_clk_lock(void); + +#define mtk_clk_lock(flags)

Re: [PATCH v3 2/4] clk: mediatek: Add initial common clock support for Mediatek SoCs.

2015-01-19 Thread Mike Turquette
Quoting James Liao (2015-01-07 18:55:01) > Hi Matthias, > > On Wed, 2015-01-07 at 18:22 +0100, Matthias Brugger wrote: > > 2015-01-07 4:25 GMT+01:00 James Liao : > > > + > > > +static void cg_set_mask(struct mtk_clk_gate *cg, u32 mask) > > > > Please add mtk_ prefix to all functions generic for

Re: [PATCH v3 2/4] clk: mediatek: Add initial common clock support for Mediatek SoCs.

2015-01-19 Thread Mike Turquette
Quoting James Liao (2015-01-07 18:55:01) Hi Matthias, On Wed, 2015-01-07 at 18:22 +0100, Matthias Brugger wrote: 2015-01-07 4:25 GMT+01:00 James Liao jamesjj.l...@mediatek.com: + +static void cg_set_mask(struct mtk_clk_gate *cg, u32 mask) Please add mtk_ prefix to all functions

Re: [PATCH v3 2/4] clk: mediatek: Add initial common clock support for Mediatek SoCs.

2015-01-07 Thread Matthias Brugger
2015-01-07 4:25 GMT+01:00 James Liao : > This patch adds common clock support for Mediatek SoCs, including plls, > muxes and clock gates. > > Change-Id: I19b5f02615610b8825fd7e028bc9b87133181bf0 > Signed-off-by: James Liao > --- > drivers/clk/mediatek/clk-gate.c | 150 >

Re: [PATCH v3 2/4] clk: mediatek: Add initial common clock support for Mediatek SoCs.

2015-01-07 Thread Matthias Brugger
2015-01-07 4:25 GMT+01:00 James Liao jamesjj.l...@mediatek.com: This patch adds common clock support for Mediatek SoCs, including plls, muxes and clock gates. Change-Id: I19b5f02615610b8825fd7e028bc9b87133181bf0 Signed-off-by: James Liao jamesjj.l...@mediatek.com ---