Re: [PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-27 Thread Roy Pledge
On 3/27/2018 7:05 AM, Robin Murphy wrote: > Hi Roy, > > On 26/03/18 20:05, Roy Pledge wrote: >> The error path in the dpaa2_dpio_probe() function was not properly >> unmapping the QBMan device memory on the error path. This was also >> missing from the dpaa2_dpio_release() function. >> >> Also

Re: [PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-27 Thread Roy Pledge
On 3/27/2018 7:05 AM, Robin Murphy wrote: > Hi Roy, > > On 26/03/18 20:05, Roy Pledge wrote: >> The error path in the dpaa2_dpio_probe() function was not properly >> unmapping the QBMan device memory on the error path. This was also >> missing from the dpaa2_dpio_release() function. >> >> Also

Re: [PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-27 Thread Robin Murphy
Hi Roy, On 26/03/18 20:05, Roy Pledge wrote: The error path in the dpaa2_dpio_probe() function was not properly unmapping the QBMan device memory on the error path. This was also missing from the dpaa2_dpio_release() function. Also addresses a memory leak of the device private data structure.

Re: [PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-27 Thread Robin Murphy
Hi Roy, On 26/03/18 20:05, Roy Pledge wrote: The error path in the dpaa2_dpio_probe() function was not properly unmapping the QBMan device memory on the error path. This was also missing from the dpaa2_dpio_release() function. Also addresses a memory leak of the device private data structure.

[PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-26 Thread Roy Pledge
The error path in the dpaa2_dpio_probe() function was not properly unmapping the QBMan device memory on the error path. This was also missing from the dpaa2_dpio_release() function. Also addresses a memory leak of the device private data structure. Signed-off-by: Roy Pledge

[PATCH v3 2/4] drivers/staging/fsl-mc: Fix DPIO error path issues

2018-03-26 Thread Roy Pledge
The error path in the dpaa2_dpio_probe() function was not properly unmapping the QBMan device memory on the error path. This was also missing from the dpaa2_dpio_release() function. Also addresses a memory leak of the device private data structure. Signed-off-by: Roy Pledge ---