Re: [PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject()

2025-02-27 Thread Petr Pavlu
On 2/25/25 18:24, Shyam Saini wrote: > On Tue, Feb 25, 2025 at 09:33:10AM +0100, Petr Pavlu wrote: >> On 2/21/25 11:42, Rasmus Villemoes wrote: >>> On Thu, Feb 13 2025, Petr Pavlu wrote: >>> On 2/11/25 22:48, Shyam Saini wrote: > In the unlikely event of the allocation failing, it is bett

Re: [PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject()

2025-02-25 Thread Shyam Saini
Hi Petr, Thank you for the reviews On Tue, Feb 25, 2025 at 09:33:10AM +0100, Petr Pavlu wrote: > On 2/21/25 11:42, Rasmus Villemoes wrote: > > On Thu, Feb 13 2025, Petr Pavlu wrote: > > > >> On 2/11/25 22:48, Shyam Saini wrote: > >>> In the unlikely event of the allocation failing, it is better

Re: [PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject()

2025-02-25 Thread Petr Pavlu
On 2/21/25 11:42, Rasmus Villemoes wrote: > On Thu, Feb 13 2025, Petr Pavlu wrote: > >> On 2/11/25 22:48, Shyam Saini wrote: >>> In the unlikely event of the allocation failing, it is better to let >>> the machine boot with a not fully populated sysfs than to kill it with >>> this BUG_ON(). All c

Re: [PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject()

2025-02-21 Thread Rasmus Villemoes
On Thu, Feb 13 2025, Petr Pavlu wrote: > On 2/11/25 22:48, Shyam Saini wrote: >> In the unlikely event of the allocation failing, it is better to let >> the machine boot with a not fully populated sysfs than to kill it with >> this BUG_ON(). All callers are already prepared for >> lookup_or_creat

Re: [PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject()

2025-02-13 Thread Petr Pavlu
On 2/11/25 22:48, Shyam Saini wrote: > In the unlikely event of the allocation failing, it is better to let > the machine boot with a not fully populated sysfs than to kill it with > this BUG_ON(). All callers are already prepared for > lookup_or_create_module_kobject() returning NULL. > > This is

[PATCH v3 2/4] kernel: refactor lookup_or_create_module_kobject()

2025-02-11 Thread Shyam Saini
In the unlikely event of the allocation failing, it is better to let the machine boot with a not fully populated sysfs than to kill it with this BUG_ON(). All callers are already prepared for lookup_or_create_module_kobject() returning NULL. This is also preparation for calling this function from