Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-09 Thread Robert Jarzmik
> + ffuart: uart@4010 { > + clocks = <_clks CLK_FFUART>; > + }; > + After another thought about your "one line" node, I think this can be even improved, so that : - uart clocks are put into pxa2xx.dtsi instead of pxa27x.dtsi - replace all

Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-09 Thread Robert Jarzmik
+ ffuart: uart@4010 { + clocks = pxa2xx_clks CLK_FFUART; + }; + After another thought about your one line node, I think this can be even improved, so that : - uart clocks are put into pxa2xx.dtsi instead of pxa27x.dtsi - replace all

Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Sergei Shtylyov
Hello. On 02/07/2015 04:16 PM, Robert Jarzmik wrote: + stuart: uart@4070 { + clocks = <_clks CLK_STUART>; + }; + The ePAPR standard tells to call such nodes "serial", not "uart". Good to know, but not for this patch. The naming

Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Robert Jarzmik
Sergei Shtylyov writes: > Hello. > > On 2/7/2015 3:39 PM, Robert Jarzmik wrote: >> +stuart: uart@4070 { >> +clocks = <_clks CLK_STUART>; >> +}; >> + > >The ePAPR standard tells to call such nodes "serial", not "uart". Good to know, but not for

Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Sergei Shtylyov
Hello. On 2/7/2015 3:39 PM, Robert Jarzmik wrote: Add clocks to the IPs already described in the pxa device-tree files. There are more clocks in the clock tree than IPs described in the current pxa device-tree. This patch ensures that : - the current description is correct - the clocks

[PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Robert Jarzmik
Add clocks to the IPs already described in the pxa device-tree files. There are more clocks in the clock tree than IPs described in the current pxa device-tree. This patch ensures that : - the current description is correct - the clocks are actually claimed, so that clock framework doesn't

[PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Robert Jarzmik
Add clocks to the IPs already described in the pxa device-tree files. There are more clocks in the clock tree than IPs described in the current pxa device-tree. This patch ensures that : - the current description is correct - the clocks are actually claimed, so that clock framework doesn't

Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Sergei Shtylyov
Hello. On 2/7/2015 3:39 PM, Robert Jarzmik wrote: Add clocks to the IPs already described in the pxa device-tree files. There are more clocks in the clock tree than IPs described in the current pxa device-tree. This patch ensures that : - the current description is correct - the clocks

Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Robert Jarzmik
Sergei Shtylyov sergei.shtyl...@cogentembedded.com writes: Hello. On 2/7/2015 3:39 PM, Robert Jarzmik wrote: +stuart: uart@4070 { +clocks = pxa2xx_clks CLK_STUART; +}; + The ePAPR standard tells to call such nodes serial, not uart. Good

Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Sergei Shtylyov
Hello. On 02/07/2015 04:16 PM, Robert Jarzmik wrote: + stuart: uart@4070 { + clocks = pxa2xx_clks CLK_STUART; + }; + The ePAPR standard tells to call such nodes serial, not uart. Good to know, but not for this patch. The naming