On Tue, Feb 04, 2014 at 07:59:21PM +0100, Jean-Francois Moine wrote:
> Mark Brown wrote:
> > You shouldn't be representing this as a separate node in the DT unless
> > there really is a distinct and reusable IP, otherwise you're putting
> > Linux implementation details in there. Describe the
On Tue, 4 Feb 2014 17:54:10 +
Mark Brown wrote:
> On Tue, Feb 04, 2014 at 06:16:05PM +0100, Jean-Francois Moine wrote:
> > Mark Brown wrote:
>
> > > > + /* load the optional CODEC */
> > > > + of_platform_populate(np, NULL, NULL, >dev);
>
> > > Why is this using
On Tue, Feb 04, 2014 at 06:16:05PM +0100, Jean-Francois Moine wrote:
> Mark Brown wrote:
> > > + /* load the optional CODEC */
> > > + of_platform_populate(np, NULL, NULL, >dev);
> > Why is this using of_platform_populate()? That's a very odd way of
> > doing things.
> The i2c does not
On Tue, Feb 04, 2014 at 02:36:50PM +0100, Lars-Peter Clausen wrote:
> On 02/04/2014 02:30 PM, Mark Brown wrote:
> >>+static const struct snd_soc_dapm_route tda_routes[] = {
> >>+ { "hdmi-out", NULL, "HDMI I2S Playback" },
> >>+ { "hdmi-out", NULL, "HDMI SPDIF Playback" },
> >>+};
> >S/PDIF.
On Tue, 4 Feb 2014 13:30:14 +
Mark Brown wrote:
> On Sun, Jan 26, 2014 at 07:45:36PM +0100, Jean-Francois Moine wrote:
>
> > + /* load the optional CODEC */
> > + of_platform_populate(np, NULL, NULL, >dev);
> > +
>
> Why is this using of_platform_populate()? That's a very odd way of
>
On 02/04/2014 02:30 PM, Mark Brown wrote:
[...]
What does this actually do? No information is being passed in to the
core function here, not even any information on if it's starting or
stopping. Looking at the rest of the code I can't help thinking it
might be clearer to inline this possibly
On Sun, Jan 26, 2014 at 07:45:36PM +0100, Jean-Francois Moine wrote:
> + /* load the optional CODEC */
> + of_platform_populate(np, NULL, NULL, >dev);
> +
Why is this using of_platform_populate()? That's a very odd way of
doing things.
> +config SND_SOC_TDA998X
> + tristate
> +
On Sun, Jan 26, 2014 at 07:45:36PM +0100, Jean-Francois Moine wrote:
+ /* load the optional CODEC */
+ of_platform_populate(np, NULL, NULL, client-dev);
+
Why is this using of_platform_populate()? That's a very odd way of
doing things.
+config SND_SOC_TDA998X
+ tristate
+
On 02/04/2014 02:30 PM, Mark Brown wrote:
[...]
What does this actually do? No information is being passed in to the
core function here, not even any information on if it's starting or
stopping. Looking at the rest of the code I can't help thinking it
might be clearer to inline this possibly
On Tue, 4 Feb 2014 13:30:14 +
Mark Brown broo...@kernel.org wrote:
On Sun, Jan 26, 2014 at 07:45:36PM +0100, Jean-Francois Moine wrote:
+ /* load the optional CODEC */
+ of_platform_populate(np, NULL, NULL, client-dev);
+
Why is this using of_platform_populate()? That's a
On Tue, Feb 04, 2014 at 02:36:50PM +0100, Lars-Peter Clausen wrote:
On 02/04/2014 02:30 PM, Mark Brown wrote:
+static const struct snd_soc_dapm_route tda_routes[] = {
+ { hdmi-out, NULL, HDMI I2S Playback },
+ { hdmi-out, NULL, HDMI SPDIF Playback },
+};
S/PDIF.
Won't this cause
On Tue, Feb 04, 2014 at 06:16:05PM +0100, Jean-Francois Moine wrote:
Mark Brown broo...@kernel.org wrote:
+ /* load the optional CODEC */
+ of_platform_populate(np, NULL, NULL, client-dev);
Why is this using of_platform_populate()? That's a very odd way of
doing things.
The i2c
On Tue, 4 Feb 2014 17:54:10 +
Mark Brown broo...@kernel.org wrote:
On Tue, Feb 04, 2014 at 06:16:05PM +0100, Jean-Francois Moine wrote:
Mark Brown broo...@kernel.org wrote:
+ /* load the optional CODEC */
+ of_platform_populate(np, NULL, NULL, client-dev);
Why is
On Tue, Feb 04, 2014 at 07:59:21PM +0100, Jean-Francois Moine wrote:
Mark Brown broo...@kernel.org wrote:
You shouldn't be representing this as a separate node in the DT unless
there really is a distinct and reusable IP, otherwise you're putting
Linux implementation details in there.
This patch adds a CODEC driver for the NXP TDA998x HDMI transmitter.
The CODEC handles both I2S and S/PDIF input and does dynamic input
switch in the TDA998x I2C driver on start/stop audio streaming.
This driver is DT only and it is loaded from its DT description as
a subnode in the TDA998x
This patch adds a CODEC driver for the NXP TDA998x HDMI transmitter.
The CODEC handles both I2S and S/PDIF input and does dynamic input
switch in the TDA998x I2C driver on start/stop audio streaming.
This driver is DT only and it is loaded from its DT description as
a subnode in the TDA998x
16 matches
Mail list logo
