Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-30 Thread Pierre Yves MORDRET
On 08/28/2017 01:48 PM, Peter Ujfalusi wrote: > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > Thanks for your invaluable inputs. This is more clear now and revise my driver > > I would not bother with

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-30 Thread Pierre Yves MORDRET
On 08/28/2017 01:48 PM, Peter Ujfalusi wrote: > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > Thanks for your invaluable inputs. This is more clear now and revise my driver > > I would not bother with

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-28 Thread Peter Ujfalusi
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-24 16:03, Pierre Yves MORDRET wrote: > Please tell me whether I'm wrong but for am335x/am437x both DMA Channels and > events are given by DT. I believe IP

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-28 Thread Peter Ujfalusi
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-24 16:03, Pierre Yves MORDRET wrote: > Please tell me whether I'm wrong but for am335x/am437x both DMA Channels and > events are given by DT. I believe IP

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-24 Thread Pierre Yves MORDRET
On 08/24/2017 07:47 AM, Peter Ujfalusi wrote: > > > On 2017-08-21 12:34, Pierre Yves MORDRET wrote: >> OK. I will redesign my driver to take into account this idea. >> >> I believe I should get rid of my custom API in DMA for channelID as well. >> Please >> confirm. Not very clear for me

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-24 Thread Pierre Yves MORDRET
On 08/24/2017 07:47 AM, Peter Ujfalusi wrote: > > > On 2017-08-21 12:34, Pierre Yves MORDRET wrote: >> OK. I will redesign my driver to take into account this idea. >> >> I believe I should get rid of my custom API in DMA for channelID as well. >> Please >> confirm. Not very clear for me

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-23 Thread Peter Ujfalusi
On 2017-08-21 12:34, Pierre Yves MORDRET wrote: > OK. I will redesign my driver to take into account this idea. > > I believe I should get rid of my custom API in DMA for channelID as well. > Please > confirm. Not very clear for me whether I can keep it or not. Yes, you should be able to get

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-23 Thread Peter Ujfalusi
On 2017-08-21 12:34, Pierre Yves MORDRET wrote: > OK. I will redesign my driver to take into account this idea. > > I believe I should get rid of my custom API in DMA for channelID as well. > Please > confirm. Not very clear for me whether I can keep it or not. Yes, you should be able to get

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-21 Thread Pierre Yves MORDRET
On 08/04/2017 04:21 PM, Peter Ujfalusi wrote: > On 08/04/2017 03:50 PM, Pierre Yves MORDRET wrote: >> Our DMAMUX can manage up to 255 request lines (only 128 is eventually >> assigned >> though) onto 16 events: 8 events mapped on 1 DMA and the 8 others onto the >> second DMA. Request line

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-21 Thread Pierre Yves MORDRET
On 08/04/2017 04:21 PM, Peter Ujfalusi wrote: > On 08/04/2017 03:50 PM, Pierre Yves MORDRET wrote: >> Our DMAMUX can manage up to 255 request lines (only 128 is eventually >> assigned >> though) onto 16 events: 8 events mapped on 1 DMA and the 8 others onto the >> second DMA. Request line

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-04 Thread Peter Ujfalusi
On 08/04/2017 03:50 PM, Pierre Yves MORDRET wrote: > Our DMAMUX can manage up to 255 request lines (only 128 is eventually assigned > though) onto 16 events: 8 events mapped on 1 DMA and the 8 others onto the > second DMA. Request line numbering is fixed (a peripheral DMA request is > assigned to

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-04 Thread Peter Ujfalusi
On 08/04/2017 03:50 PM, Pierre Yves MORDRET wrote: > Our DMAMUX can manage up to 255 request lines (only 128 is eventually assigned > though) onto 16 events: 8 events mapped on 1 DMA and the 8 others onto the > second DMA. Request line numbering is fixed (a peripheral DMA request is > assigned to

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-04 Thread Pierre Yves MORDRET
On 08/03/2017 11:48 AM, Peter Ujfalusi wrote: > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 2017-08-03 12:00, Pierre Yves MORDRET wrote: >>> What I actually mean is that you should not need to modify

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-04 Thread Pierre Yves MORDRET
On 08/03/2017 11:48 AM, Peter Ujfalusi wrote: > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 2017-08-03 12:00, Pierre Yves MORDRET wrote: >>> What I actually mean is that you should not need to modify

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-03 Thread Peter Ujfalusi
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-03 12:00, Pierre Yves MORDRET wrote: >> What I actually mean is that you should not need to modify the DMA >> driver at all. >> According to stm32-dma.txt:

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-03 Thread Peter Ujfalusi
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-03 12:00, Pierre Yves MORDRET wrote: >> What I actually mean is that you should not need to modify the DMA >> driver at all. >> According to stm32-dma.txt:

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-03 Thread Pierre Yves MORDRET
On 08/03/2017 08:42 AM, Peter Ujfalusi wrote: > our mail server started to mangle outgoing mails, sorry for that, we are > trying to resolve that... No problem ;) > > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile:

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-03 Thread Pierre Yves MORDRET
On 08/03/2017 08:42 AM, Peter Ujfalusi wrote: > our mail server started to mangle outgoing mails, sorry for that, we are > trying to resolve that... No problem ;) > > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile:

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-03 Thread Peter Ujfalusi
our mail server started to mangle outgoing mails, sorry for that, we are trying to resolve that... Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-02 17:28, Pierre Yves MORDRET wrote: Correct router

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-03 Thread Peter Ujfalusi
our mail server started to mangle outgoing mails, sorry for that, we are trying to resolve that... Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-02 17:28, Pierre Yves MORDRET wrote: Correct router

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-02 Thread Pierre Yves MORDRET
On 08/02/2017 04:09 PM, Peter Ujfalusi wrote: > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 2017-08-02 16:11, Pierre Yves MORDRET wrote: >> Our SoC works with or without DMAMUX. Both binding is

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-02 Thread Pierre Yves MORDRET
On 08/02/2017 04:09 PM, Peter Ujfalusi wrote: > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 2017-08-02 16:11, Pierre Yves MORDRET wrote: >> Our SoC works with or without DMAMUX. Both binding is

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-02 Thread Peter Ujfalusi
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-02 16:11, Pierre Yves MORDRET wrote: Our SoC works with or without DMAMUX. Both binding is allowed. Using only DMA a ChannelId and request line is part of

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-02 Thread Peter Ujfalusi
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 2017-08-02 16:11, Pierre Yves MORDRET wrote: Our SoC works with or without DMAMUX. Both binding is allowed. Using only DMA a ChannelId and request line is part of

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-02 Thread Pierre Yves MORDRET
On 08/02/2017 11:19 AM, Peter Ujfalusi wrote: > > > On 2017-08-02 07:55, Vinod Koul wrote: >> On Tue, Aug 01, 2017 at 09:32:50AM +, Pierre Yves MORDRET wrote: >>> >>> >>> On 07/31/2017 02:31 PM, Vinod Koul wrote: On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote:

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-02 Thread Pierre Yves MORDRET
On 08/02/2017 11:19 AM, Peter Ujfalusi wrote: > > > On 2017-08-02 07:55, Vinod Koul wrote: >> On Tue, Aug 01, 2017 at 09:32:50AM +, Pierre Yves MORDRET wrote: >>> >>> >>> On 07/31/2017 02:31 PM, Vinod Koul wrote: On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote:

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-02 Thread Peter Ujfalusi
On 2017-08-02 07:55, Vinod Koul wrote: On Tue, Aug 01, 2017 at 09:32:50AM +, Pierre Yves MORDRET wrote: On 07/31/2017 02:31 PM, Vinod Koul wrote: On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote: + +#ifndef __DMA_STM32_DMAMUX_H +#define __DMA_STM32_DMAMUX_H + +#if

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-02 Thread Peter Ujfalusi
On 2017-08-02 07:55, Vinod Koul wrote: On Tue, Aug 01, 2017 at 09:32:50AM +, Pierre Yves MORDRET wrote: On 07/31/2017 02:31 PM, Vinod Koul wrote: On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote: + +#ifndef __DMA_STM32_DMAMUX_H +#define __DMA_STM32_DMAMUX_H + +#if

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-01 Thread Vinod Koul
On Tue, Aug 01, 2017 at 09:32:50AM +, Pierre Yves MORDRET wrote: > > > On 07/31/2017 02:31 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote: > >> + > >> +#ifndef __DMA_STM32_DMAMUX_H > >> +#define __DMA_STM32_DMAMUX_H > >> + >

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-01 Thread Vinod Koul
On Tue, Aug 01, 2017 at 09:32:50AM +, Pierre Yves MORDRET wrote: > > > On 07/31/2017 02:31 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote: > >> + > >> +#ifndef __DMA_STM32_DMAMUX_H > >> +#define __DMA_STM32_DMAMUX_H > >> + >

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-01 Thread Pierre Yves MORDRET
On 07/31/2017 02:31 PM, Vinod Koul wrote: > On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote: >> + >> +#ifndef __DMA_STM32_DMAMUX_H >> +#define __DMA_STM32_DMAMUX_H >> + >> +#if defined(CONFIG_STM32_DMAMUX) >> +int stm32_dmamux_set_config(struct device

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-08-01 Thread Pierre Yves MORDRET
On 07/31/2017 02:31 PM, Vinod Koul wrote: > On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote: >> + >> +#ifndef __DMA_STM32_DMAMUX_H >> +#define __DMA_STM32_DMAMUX_H >> + >> +#if defined(CONFIG_STM32_DMAMUX) >> +int stm32_dmamux_set_config(struct device

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-31 Thread Vinod Koul
On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote: > + > +#ifndef __DMA_STM32_DMAMUX_H > +#define __DMA_STM32_DMAMUX_H > + > +#if defined(CONFIG_STM32_DMAMUX) > +int stm32_dmamux_set_config(struct device *dev, void *route_data, u32 > chan_id);

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-31 Thread Vinod Koul
On Wed, Jul 26, 2017 at 07:38:02AM +, Pierre Yves MORDRET wrote: > + > +#ifndef __DMA_STM32_DMAMUX_H > +#define __DMA_STM32_DMAMUX_H > + > +#if defined(CONFIG_STM32_DMAMUX) > +int stm32_dmamux_set_config(struct device *dev, void *route_data, u32 > chan_id);

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-26 Thread Pierre Yves MORDRET
On 07/26/2017 07:29 AM, Vinod Koul wrote: > On Mon, Jul 24, 2017 at 01:55:10PM +, Pierre Yves MORDRET wrote: > + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -ENODEV; + + iomem = devm_ioremap_resource(>dev, res);

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-26 Thread Pierre Yves MORDRET
On 07/26/2017 07:29 AM, Vinod Koul wrote: > On Mon, Jul 24, 2017 at 01:55:10PM +, Pierre Yves MORDRET wrote: > + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -ENODEV; + + iomem = devm_ioremap_resource(>dev, res);

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-25 Thread Vinod Koul
On Mon, Jul 24, 2017 at 01:55:10PM +, Pierre Yves MORDRET wrote: > >> + > >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + if (!res) > >> + return -ENODEV; > >> + > >> + iomem = devm_ioremap_resource(>dev, res); > >> + if (!iomem) > >> + return -ENOMEM;

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-25 Thread Vinod Koul
On Mon, Jul 24, 2017 at 01:55:10PM +, Pierre Yves MORDRET wrote: > >> + > >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + if (!res) > >> + return -ENODEV; > >> + > >> + iomem = devm_ioremap_resource(>dev, res); > >> + if (!iomem) > >> + return -ENOMEM;

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-24 Thread Pierre Yves MORDRET
On 07/22/2017 08:51 AM, Vinod Koul wrote: > On Thu, Jul 06, 2017 at 02:20:20PM +0200, Pierre-Yves MORDRET wrote: >> +static int stm32_dmamux_probe(struct platform_device *pdev) >> +{ >> +struct device_node *node = pdev->dev.of_node; >> +struct device_node *dma_node; >> +struct

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-24 Thread Pierre Yves MORDRET
On 07/22/2017 08:51 AM, Vinod Koul wrote: > On Thu, Jul 06, 2017 at 02:20:20PM +0200, Pierre-Yves MORDRET wrote: >> +static int stm32_dmamux_probe(struct platform_device *pdev) >> +{ >> +struct device_node *node = pdev->dev.of_node; >> +struct device_node *dma_node; >> +struct

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-22 Thread Vinod Koul
On Thu, Jul 06, 2017 at 02:20:20PM +0200, Pierre-Yves MORDRET wrote: > +static int stm32_dmamux_probe(struct platform_device *pdev) > +{ > + struct device_node *node = pdev->dev.of_node; > + struct device_node *dma_node; > + struct stm32_dmamux_data *stm32_dmamux; > + struct

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-22 Thread Vinod Koul
On Thu, Jul 06, 2017 at 02:20:20PM +0200, Pierre-Yves MORDRET wrote: > +static int stm32_dmamux_probe(struct platform_device *pdev) > +{ > + struct device_node *node = pdev->dev.of_node; > + struct device_node *dma_node; > + struct stm32_dmamux_data *stm32_dmamux; > + struct

[PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-06 Thread Pierre-Yves MORDRET
This patch implements the STM32 DMAMUX driver. The DMAMUX request multiplexer allows routing a DMA request line between the peripherals and the DMA controllers of the product. The routing function is ensured by a programmable multi-channel DMA request line multiplexer. Each channel selects a

[PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

2017-07-06 Thread Pierre-Yves MORDRET
This patch implements the STM32 DMAMUX driver. The DMAMUX request multiplexer allows routing a DMA request line between the peripherals and the DMA controllers of the product. The routing function is ensured by a programmable multi-channel DMA request line multiplexer. Each channel selects a