Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc

2017-06-28 Thread Wolfram Sang
> Wolframs call. I don't mind either way. I can send a v4 or send a new > series on top of i2c.git#for-next. I think we can work incrementally on what I pushed out already. Thanks! signature.asc Description: PGP signature

Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc

2017-06-28 Thread Chris Packham
On 28/06/17 21:25, Andy Shevchenko wrote: > On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham > wrote: >> Make use of struct gpio_desc which allows us to specify the active state >> of the reset pin. > >> + if (gpio_is_valid(platform_data->gpio)) { > > No way, it should be provided by

Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc

2017-06-28 Thread Andy Shevchenko
On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham wrote: > Make use of struct gpio_desc which allows us to specify the active state > of the reset pin. > + if (gpio_is_valid(platform_data->gpio)) { No way, it should be provided by GPIO lookup table. > + ret = de

Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc

2017-06-27 Thread Wolfram Sang
On Mon, Jun 26, 2017 at 12:44:31PM +1200, Chris Packham wrote: > Make use of struct gpio_desc which allows us to specify the active state > of the reset pin. > > Signed-off-by: Chris Packham Applied to for-next, thanks! signature.asc Description: PGP signature

[PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc

2017-06-25 Thread Chris Packham
Make use of struct gpio_desc which allows us to specify the active state of the reset pin. Signed-off-by: Chris Packham --- Changes in v3: - New, replaces "i2c: pca-platform: use gpio_is_valid" - Using struct gpio_desc is required to make the flags stick. Because those flags now correctly indic