Re: [PATCH v3 2/5] media: i2c: max9286: Use "maxim,gpio-poc" property

2021-04-16 Thread Laurent Pinchart
Hi Jacopo, On Fri, Apr 16, 2021 at 09:43:07AM +0200, Jacopo Mondi wrote: > On Thu, Apr 15, 2021 at 10:14:05PM +0300, Laurent Pinchart wrote: > > > > > + /* GPIO values default to high */ > > > > > + priv->gpio_state = BIT(0) | BIT(1); > > > > > > > > Why is that ? > > > > >

Re: [PATCH v3 2/5] media: i2c: max9286: Use "maxim,gpio-poc" property

2021-04-16 Thread Jacopo Mondi
Hi Laurent, On Thu, Apr 15, 2021 at 10:14:05PM +0300, Laurent Pinchart wrote: > > > > + /* GPIO values default to high */ > > > > + priv->gpio_state = BIT(0) | BIT(1); > > > > > > Why is that ? > > > > > As the set/get functions of gpiochip use the gpio_state and I want

Re: [PATCH v3 2/5] media: i2c: max9286: Use "maxim,gpio-poc" property

2021-04-15 Thread Laurent Pinchart
Hi Jacopo, On Thu, Apr 15, 2021 at 08:58:48AM +0200, Jacopo Mondi wrote: > On Thu, Apr 15, 2021 at 03:00:56AM +0300, Laurent Pinchart wrote: > > On Wed, Apr 14, 2021 at 03:51:25PM +0200, Jacopo Mondi wrote: > > > The 'maxim,gpio-poc' property is used when the remote camera > > > power-over-coax is

Re: [PATCH v3 2/5] media: i2c: max9286: Use "maxim,gpio-poc" property

2021-04-14 Thread Jacopo Mondi
Hi Laurent, On Thu, Apr 15, 2021 at 03:00:56AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Wed, Apr 14, 2021 at 03:51:25PM +0200, Jacopo Mondi wrote: > > The 'maxim,gpio-poc' property is used when the remote camera > > power-over-coax is controlled by one of the

Re: [PATCH v3 2/5] media: i2c: max9286: Use "maxim,gpio-poc" property

2021-04-14 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wed, Apr 14, 2021 at 03:51:25PM +0200, Jacopo Mondi wrote: > The 'maxim,gpio-poc' property is used when the remote camera > power-over-coax is controlled by one of the MAX9286 gpio lines, > to instruct the driver about which line to use and what the line > p

[PATCH v3 2/5] media: i2c: max9286: Use "maxim,gpio-poc" property

2021-04-14 Thread Jacopo Mondi
The 'maxim,gpio-poc' property is used when the remote camera power-over-coax is controlled by one of the MAX9286 gpio lines, to instruct the driver about which line to use and what the line polarity is. Add to the max9286 driver support for parsing the newly introduce property and use it if availa