Re: [PATCH v3 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-21 Thread Russell King - ARM Linux admin
On Fri, Jun 21, 2019 at 09:34:50AM +0100, Parshuram Thombare wrote: > This patch add support for SGMII interface) and > 2.5Gbps MAC in Cadence ethernet controller driver. Also, I'm not sure that merely using PHY_INTERFACE_MODE_SGMII with a speed of 2.5Gbps is really on for up-clocked SGMII. Cisco

Re: [PATCH v3 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-21 Thread Russell King - ARM Linux admin
On Fri, Jun 21, 2019 at 09:34:50AM +0100, Parshuram Thombare wrote: > @@ -486,23 +503,54 @@ static void gem_mac_config(struct phylink_config > *pl_config, unsigned int mode, > { > struct net_device *netdev = to_net_dev(pl_config->dev); > struct macb *bp = netdev_priv(netdev); > +

[PATCH v3 2/5] net: macb: add support for sgmii MAC-PHY interface

2019-06-21 Thread Parshuram Thombare
This patch add support for SGMII interface) and 2.5Gbps MAC in Cadence ethernet controller driver. Signed-off-by: Parshuram Thombare --- drivers/net/ethernet/cadence/macb.h | 54 +--- drivers/net/ethernet/cadence/macb_main.c | 108 +-- 2 files changed, 140 inser