Re: [PATCH v3 2/5] soc: qcom: Introduce QMI helpers

2017-11-21 Thread Bjorn Andersson
On Fri 17 Nov 18:11 PST 2017, Chris Lew wrote: > On 11/15/2017 12:10 PM, Bjorn Andersson wrote: > [..]> +static void qmi_handle_message(struct qmi_handle *qmi, > > + struct sockaddr_qrtr *sq, > > + const void *buf, size_t len) > > +{ > > + const s

Re: [PATCH v3 2/5] soc: qcom: Introduce QMI helpers

2017-11-17 Thread Chris Lew
On 11/15/2017 12:10 PM, Bjorn Andersson wrote: [..]> +static void qmi_handle_message(struct qmi_handle *qmi, + struct sockaddr_qrtr *sq, + const void *buf, size_t len) +{ + const struct qmi_header *hdr; + struct qmi_txn tmp_tx

Re: [PATCH v3 2/5] soc: qcom: Introduce QMI helpers

2017-11-16 Thread Bjorn Andersson
On Thu 16 Nov 04:11 PST 2017, Srinivas Kandagatla wrote: > On 15/11/17 20:10, Bjorn Andersson wrote: [..] > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > > index 91b70b170a82..9718f1c41e3d 100644 > > --- a/drivers/soc/qcom/Kconfig > > +++ b/drivers/soc/qcom/Kconfig > > @@ -37

Re: [PATCH v3 2/5] soc: qcom: Introduce QMI helpers

2017-11-16 Thread Srinivas Kandagatla
On 15/11/17 20:10, Bjorn Andersson wrote: Drivers that needs to communicate with a remote QMI service all has to perform the operations of discovering the service, encoding and decoding the messages and operate the socket. This introduces an abstraction for these common operations, reducing mos

[PATCH v3 2/5] soc: qcom: Introduce QMI helpers

2017-11-15 Thread Bjorn Andersson
Drivers that needs to communicate with a remote QMI service all has to perform the operations of discovering the service, encoding and decoding the messages and operate the socket. This introduces an abstraction for these common operations, reducing most of the duplication in such cases. Signed-of