Re: [PATCH v3 2/6] serial: imx: only set dma_is_rxing when DMA starts

2017-09-21 Thread Uwe Kleine-König
On Thu, Sep 21, 2017 at 05:18:13PM +0100, Martyn Welch wrote: > From: Romain Perier > > The variable dma_is_rxing is currently set to 1 in imx_disable_rx_int(). > This is problematic as: > > - whilst imx_disable_rx_int() is currently always called before > start_rx_dma() this dependency isn't

[PATCH v3 2/6] serial: imx: only set dma_is_rxing when DMA starts

2017-09-21 Thread Martyn Welch
From: Romain Perier The variable dma_is_rxing is currently set to 1 in imx_disable_rx_int(). This is problematic as: - whilst imx_disable_rx_int() is currently always called before start_rx_dma() this dependency isn't obvious. - start_rx_dma() does error checking and might exit without enabl