Re: [PATCH v3 2/7] drivers: regulator: qcom_spmi: Refactor get_mode/set_mode

2019-06-13 Thread Jeffrey Hugo
On Thu, Jun 13, 2019 at 9:24 AM Bjorn Andersson wrote: > > On Thu 13 Jun 08:12 PDT 2019, Bjorn Andersson wrote: > > > On Thu 13 Jun 07:22 PDT 2019, Jeffrey Hugo wrote: > > > > > spmi_regulator_common_get_mode and spmi_regulator_common_set_mode use > > > multi-level ifs which mirror a switch statem

Re: [PATCH v3 2/7] drivers: regulator: qcom_spmi: Refactor get_mode/set_mode

2019-06-13 Thread Bjorn Andersson
On Thu 13 Jun 08:12 PDT 2019, Bjorn Andersson wrote: > On Thu 13 Jun 07:22 PDT 2019, Jeffrey Hugo wrote: > > > spmi_regulator_common_get_mode and spmi_regulator_common_set_mode use > > multi-level ifs which mirror a switch statement. Refactor to use a switch > > statement to make the code flow m

Re: [PATCH v3 2/7] drivers: regulator: qcom_spmi: Refactor get_mode/set_mode

2019-06-13 Thread Bjorn Andersson
On Thu 13 Jun 07:22 PDT 2019, Jeffrey Hugo wrote: > spmi_regulator_common_get_mode and spmi_regulator_common_set_mode use > multi-level ifs which mirror a switch statement. Refactor to use a switch > statement to make the code flow more clear. > > Signed-off-by: Jeffrey Hugo > --- > drivers/re

[PATCH v3 2/7] drivers: regulator: qcom_spmi: Refactor get_mode/set_mode

2019-06-13 Thread Jeffrey Hugo
spmi_regulator_common_get_mode and spmi_regulator_common_set_mode use multi-level ifs which mirror a switch statement. Refactor to use a switch statement to make the code flow more clear. Signed-off-by: Jeffrey Hugo --- drivers/regulator/qcom_spmi-regulator.c | 28 - 1 f