Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-10-04 Thread Noralf Trønnes
Den 03.10.2016 21:42, skrev Eric Anholt: Noralf Trønnes writes: Den 29.09.2016 00:00, skrev Eric Anholt: Noralf Trønnes writes: If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0), the driver has no way to fill/drain the FIFO to stop the interrupts. In this case the cont

Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-10-03 Thread Eric Anholt
Noralf Trønnes writes: > Den 29.09.2016 00:00, skrev Eric Anholt: >> Noralf Trønnes writes: >> >>> If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0), >>> the driver has no way to fill/drain the FIFO to stop the interrupts. >>> In this case the controller has to be disabled an

Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-10-03 Thread Eric Anholt
Noralf Trønnes writes: > Den 29.09.2016 07:37, skrev Stefan Wahren: >>> Noralf Trønnes hat am 29. September 2016 um 00:22 >>> geschrieben: >>> >>> >>> >>> Den 29.09.2016 00:00, skrev Eric Anholt: Noralf Trønnes writes: > If an unexpected TXW or RXR interrupt occurs (msg_buf_remain

Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-10-02 Thread Noralf Trønnes
Den 29.09.2016 07:37, skrev Stefan Wahren: Noralf Trønnes hat am 29. September 2016 um 00:22 geschrieben: Den 29.09.2016 00:00, skrev Eric Anholt: Noralf Trønnes writes: If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0), the driver has no way to fill/drain the FIFO to

Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-09-28 Thread Stefan Wahren
> Noralf Trønnes hat am 29. September 2016 um 00:22 > geschrieben: > > > > Den 29.09.2016 00:00, skrev Eric Anholt: > > Noralf Trønnes writes: > > > >> If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0), > >> the driver has no way to fill/drain the FIFO to stop the interrup

Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-09-28 Thread Noralf Trønnes
Den 29.09.2016 00:00, skrev Eric Anholt: Noralf Trønnes writes: If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0), the driver has no way to fill/drain the FIFO to stop the interrupts. In this case the controller has to be disabled and the transfer completed to avoid hang.

Re: [PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-09-28 Thread Eric Anholt
Noralf Trønnes writes: > If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0), > the driver has no way to fill/drain the FIFO to stop the interrupts. > In this case the controller has to be disabled and the transfer > completed to avoid hang. > > (CLKT | ERR) and DONE interrupts

[PATCH v3 2/7] i2c: bcm2835: Protect against unexpected TXW/RXR interrupts

2016-09-28 Thread Noralf Trønnes
If an unexpected TXW or RXR interrupt occurs (msg_buf_remaining == 0), the driver has no way to fill/drain the FIFO to stop the interrupts. In this case the controller has to be disabled and the transfer completed to avoid hang. (CLKT | ERR) and DONE interrupts are completed in their own paths, an