Re: [PATCH v3 2/7] kprobes: Show blacklist addresses as same as kallsyms does

On Fri, 27 Apr 2018 09:14:17 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > + /* > > +* As long as kallsyms shows the address, kprobes blacklist also > > +* show it, Or, it shows null address and symbol. > > +*/ > > Please _read_ the comments you write! > > In whi

Re: [PATCH v3 2/7] kprobes: Show blacklist addresses as same as kallsyms does

* Masami Hiramatsu wrote: > + /* > + * As long as kallsyms shows the address, kprobes blacklist also > + * show it, Or, it shows null address and symbol. > + */ Please _read_ the comments you write! In which universe does a capitalized 'Or' make sense, even if we ignore the

[PATCH v3 2/7] kprobes: Show blacklist addresses as same as kallsyms does

Show kprobes blacklist addresses under same condition of showing kallsyms addresses. Since there are several name conflict for local symbols, kprobe blacklist needs to show each addresses so that user can identify where is on blacklist by comparing with kallsyms. Signed-off-by: Masami Hiramatsu