Re: [PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code

2019-10-04 Thread Kirill A. Shutemov
On Fri, Oct 04, 2019 at 02:58:59PM +0200, Thomas Hellström (VMware) wrote: > On 10/4/19 2:37 PM, Kirill A. Shutemov wrote: > > On Thu, Oct 03, 2019 at 01:32:45PM +0200, Thomas Hellström (VMware) wrote: > > > > > + * If @mapping allows faulting of huge pmds and puds, it is > > > > > desirable >

Re: [PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code

2019-10-04 Thread VMware
On 10/4/19 2:37 PM, Kirill A. Shutemov wrote: On Thu, Oct 03, 2019 at 01:32:45PM +0200, Thomas Hellström (VMware) wrote: + * If @mapping allows faulting of huge pmds and puds, it is desirable + * that its huge_fault() handler blocks while this function is running on + * @mapping.

Re: [PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code

2019-10-04 Thread Kirill A. Shutemov
On Thu, Oct 03, 2019 at 01:32:45PM +0200, Thomas Hellström (VMware) wrote: > > > + * If @mapping allows faulting of huge pmds and puds, it is desirable > > > + * that its huge_fault() handler blocks while this function is running > > > on > > > + * @mapping. Otherwise a race may occur where

Re: [PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code

2019-10-03 Thread VMware
On 10/3/19 1:17 PM, Kirill A. Shutemov wrote: On Wed, Oct 02, 2019 at 03:47:25PM +0200, Thomas Hellström (VMware) wrote: From: Thomas Hellstrom For users that want to travers all page table entries pointing into a region of a struct address_space mapping, introduce a walk_page_mapping()

Re: [PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code

2019-10-03 Thread Kirill A. Shutemov
On Wed, Oct 02, 2019 at 03:47:25PM +0200, Thomas Hellström (VMware) wrote: > From: Thomas Hellstrom > > For users that want to travers all page table entries pointing into a > region of a struct address_space mapping, introduce a walk_page_mapping() > function. > > The walk_page_mapping()

Re: [PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code

2019-10-02 Thread Linus Torvalds
On Wed, Oct 2, 2019 at 6:47 AM Thomas Hellström (VMware) wrote: > > From: Thomas Hellstrom > > For users that want to travers all page table entries pointing into a > region of a struct address_space mapping, introduce a walk_page_mapping() > function. This looks non-offensive to me. My main

[PATCH v3 2/7] mm: Add a walk_page_mapping() function to the pagewalk code

2019-10-02 Thread VMware
From: Thomas Hellstrom For users that want to travers all page table entries pointing into a region of a struct address_space mapping, introduce a walk_page_mapping() function. The walk_page_mapping() function will be initially be used for dirty- tracking in virtual graphics drivers. Cc: