Re: [PATCH v3 2/7] x86: kvm: svm: propagate errors from skip_emulated_instruction()

2019-08-09 Thread Sean Christopherson
On Thu, Aug 08, 2019 at 07:30:46PM +0200, Vitaly Kuznetsov wrote: > On AMD, kvm_x86_ops->skip_emulated_instruction(vcpu) can, in theory, > fail: in !nrips case we call kvm_emulate_instruction(EMULTYPE_SKIP). > Currently, we only do printk(KERN_DEBUG) when this happens and this > is not ideal. Propa

[PATCH v3 2/7] x86: kvm: svm: propagate errors from skip_emulated_instruction()

2019-08-08 Thread Vitaly Kuznetsov
On AMD, kvm_x86_ops->skip_emulated_instruction(vcpu) can, in theory, fail: in !nrips case we call kvm_emulate_instruction(EMULTYPE_SKIP). Currently, we only do printk(KERN_DEBUG) when this happens and this is not ideal. Propagate the error up the stack. On VMX, skip_emulated_instruction() doesn't