Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-25 Thread Dan Williams
On Mon, Apr 25, 2022 at 9:05 AM Dan Williams wrote: > > On Mon, Apr 25, 2022 at 3:33 AM Peter Zijlstra wrote: > > > > On Sat, Apr 23, 2022 at 10:27:52AM -0700, Dan Williams wrote: > > > > > ...so I'm going to drop it and just add a comment about the > > > expectations. As Peter said there's

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-25 Thread Dan Williams
On Mon, Apr 25, 2022 at 3:33 AM Peter Zijlstra wrote: > > On Sat, Apr 23, 2022 at 10:27:52AM -0700, Dan Williams wrote: > > > ...so I'm going to drop it and just add a comment about the > > expectations. As Peter said there's already a multitude of ways to > > cause false positive / negative

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-25 Thread Peter Zijlstra
On Sat, Apr 23, 2022 at 10:27:52AM -0700, Dan Williams wrote: > ...so I'm going to drop it and just add a comment about the > expectations. As Peter said there's already a multitude of ways to > cause false positive / negative results with lockdep so this is just > one more area where one needs

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-23 Thread Dan Williams
On Fri, Apr 22, 2022 at 5:08 PM Dan Williams wrote: > > On Fri, Apr 22, 2022 at 4:58 PM Ira Weiny wrote: > > > > On Thu, Apr 21, 2022 at 08:33:18AM -0700, Dan Williams wrote: > > > The CXL "root" device, ACPI0017, is an attach point for coordinating > > > platform level CXL resources and is the

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-22 Thread Dan Williams
On Fri, Apr 22, 2022 at 4:58 PM Ira Weiny wrote: > > On Thu, Apr 21, 2022 at 08:33:18AM -0700, Dan Williams wrote: > > The CXL "root" device, ACPI0017, is an attach point for coordinating > > platform level CXL resources and is the parent device for a CXL port > > topology tree. As such it has

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-22 Thread Ira Weiny
On Thu, Apr 21, 2022 at 08:33:18AM -0700, Dan Williams wrote: > The CXL "root" device, ACPI0017, is an attach point for coordinating > platform level CXL resources and is the parent device for a CXL port > topology tree. As such it has distinct locking rules relative to other > CXL subsystem

Re: [PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-21 Thread Greg Kroah-Hartman
On Thu, Apr 21, 2022 at 08:33:18AM -0700, Dan Williams wrote: > The CXL "root" device, ACPI0017, is an attach point for coordinating > platform level CXL resources and is the parent device for a CXL port > topology tree. As such it has distinct locking rules relative to other > CXL subsystem

[PATCH v3 2/8] cxl/acpi: Add root device lockdep validation

2022-04-21 Thread Dan Williams
The CXL "root" device, ACPI0017, is an attach point for coordinating platform level CXL resources and is the parent device for a CXL port topology tree. As such it has distinct locking rules relative to other CXL subsystem objects, but because it is an ACPI device the lock class is established