Re: [PATCH v3 2/9] watchdog: Introduce hardware maximum timeout in watchdog core

2015-09-09 Thread Uwe Kleine-König
Hello Guenter, On Tue, Sep 08, 2015 at 02:07:30PM -0700, Guenter Roeck wrote: > On Tue, Sep 08, 2015 at 10:03:32PM +0200, Uwe Kleine-König wrote: > > On Tue, Sep 08, 2015 at 06:47:26AM -0700, Guenter Roeck wrote: > > > On 09/08/2015 03:33 AM, Uwe Kleine-König wrote: > > > >>+ virt_timeout =

Re: [PATCH v3 2/9] watchdog: Introduce hardware maximum timeout in watchdog core

2015-09-08 Thread Guenter Roeck
On Tue, Sep 08, 2015 at 10:03:32PM +0200, Uwe Kleine-König wrote: > Hello Guenter, > > On Tue, Sep 08, 2015 at 06:47:26AM -0700, Guenter Roeck wrote: > > On 09/08/2015 03:33 AM, Uwe Kleine-König wrote: > > >Hello, > > > > > > > >>[...] > > >>+static long watchdog_next_keepalive(struct watchdog_de

Re: [PATCH v3 2/9] watchdog: Introduce hardware maximum timeout in watchdog core

2015-09-08 Thread Uwe Kleine-König
Hello Guenter, On Tue, Sep 08, 2015 at 06:47:26AM -0700, Guenter Roeck wrote: > On 09/08/2015 03:33 AM, Uwe Kleine-König wrote: > >Hello, > > > > >>[...] > >>+static long watchdog_next_keepalive(struct watchdog_device *wdd) > >>+{ > >>+ unsigned int hw_timeout_ms = wdd->timeout * 1000; > >>+

Re: [PATCH v3 2/9] watchdog: Introduce hardware maximum timeout in watchdog core

2015-09-08 Thread Guenter Roeck
Hi Uwe, On 09/08/2015 03:33 AM, Uwe Kleine-König wrote: Hello, [...] +static long watchdog_next_keepalive(struct watchdog_device *wdd) +{ + unsigned int hw_timeout_ms = wdd->timeout * 1000; + unsigned long keepalive_interval; + unsigned long last_heartbeat; + unsigned

Re: [PATCH v3 2/9] watchdog: Introduce hardware maximum timeout in watchdog core

2015-09-08 Thread Uwe Kleine-König
Hello, On Sat, Aug 29, 2015 at 12:32:31PM -0700, Guenter Roeck wrote: > diff --git a/Documentation/watchdog/watchdog-kernel-api.txt > b/Documentation/watchdog/watchdog-kernel-api.txt > index d8b0d3367706..3306249aa17d 100644 > --- a/Documentation/watchdog/watchdog-kernel-api.txt > +++ b/Documenta

[PATCH v3 2/9] watchdog: Introduce hardware maximum timeout in watchdog core

2015-08-29 Thread Guenter Roeck
Introduce an optional hardware maximum timeout in the watchdog core. The hardware maximum timeout can be lower than the maximum timeout. Drivers can set the maximum hardware timeout value in the watchdog data structure. If the configured timeout exceeds the maximum hardware timeout, the watchdog c