Re: [PATCH v3 21/21] sparc64: use match_string() helper

2018-06-20 Thread Yisheng Xie
Hi Andy, Sorry for late response. I will take your suggestion in next version. Thanks Yisheng On 2018/6/6 13:01, Andy Shevchenko wrote: > On Wed, Jun 6, 2018 at 5:19 AM, Yisheng Xie wrote: >> match_string() returns the index of an array for a matching string, >> which can be used instead of ope

Re: [PATCH v3 21/21] sparc64: use match_string() helper

2018-06-05 Thread Andy Shevchenko
On Wed, Jun 6, 2018 at 5:19 AM, Yisheng Xie wrote: > match_string() returns the index of an array for a matching string, > which can be used instead of open coded variant. > Thanks for an update. My comments below. I think you need to mentioned the string literal change in the commit message. >

[PATCH v3 21/21] sparc64: use match_string() helper

2018-06-05 Thread Yisheng Xie
match_string() returns the index of an array for a matching string, which can be used instead of open coded variant. Cc: "David S. Miller" Cc: Anthony Yznaga Cc: Pavel Tatashin Cc: sparcli...@vger.kernel.org Signed-off-by: Yisheng Xie --- v3: - add string literal instead of NULL for array hwc